Open
Conversation
When simplejson is installed, `requests` behaves differently https://github.com/psf/requests/blob/1764cc938efc3cc9720188dfa6c3852c45211aa0/src/requests/compat.py#L59-L64 which affects custom JSONEncode/Decoders Instead of relying on simplejson for decimal support implement decimal support directly Remove the `internal_json` vs `stock_json` test comparison
|
this is a great PR, removing the dependency in simplejson which btw has been pinned at a recent version (with no actual requirement on that version) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Instead of relying on simplejson for decimal support implement decimal support directly
Remove the
internal_jsonvsstock_jsontest comparisonTarget (OCI, Managed Runtime, both): Managed runtime
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Motivation:
When simplejson is installed,
requestsbehaves differently https://github.com/psf/requests/blob/1764cc938efc3cc9720188dfa6c3852c45211aa0/src/requests/compat.py#L59-L64 which affects custom JSONEncode/Decoders