Move post_init_error again under exception handling block#171
Open
antonpirker wants to merge 1 commit intoaws:mainfrom
Open
Move post_init_error again under exception handling block#171antonpirker wants to merge 1 commit intoaws:mainfrom
post_init_error again under exception handling block#171antonpirker wants to merge 1 commit intoaws:mainfrom
Conversation
…e possibility of sys.exc_info() in monkey patched post_init_error function
Contributor
|
Hey this change will break the functionality because we call the However we could refactor the piece of code to just have the In this way we can keep the error reporting functionality and your monkey patching would work. Although I would recommend to to take dependency on such specific behaviour as it is bound to change over a period of time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #172
Description of changes:
Move
post_init_erroragain under exception handling block to preserve possibility of callingsys.exc_info()in monkey patchedpost_init_errorfunction.Target (OCI, Managed Runtime, both):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.