Open
Conversation
Author
|
Hi @godcrampy @maxday @trivenay, could this PR and #123 be reviewed so that a patch version can be released? These 2 fixes would solve several of the build issues reported over the past 2 years. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #116
Description of changes:
When attempting to run the post-install script with Python >= 3.12, the following error occurs:
This is because
node-gypv9.4.0 relies on thedistutilsmodule which was removed from Python in v3.12.node-gypv10 fixes this issue by relying on a version ofgyp-nextthat removes the reliance on thedistutilsmodule and vendors in thepackagingmodule.To allow the post-install script to work on Python >= 3.12, we bump the version of
node-gypto the latest version as of this PR.Target (OCI, Managed Runtime, both):
OCI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.