Fix EventHandlerLoaderTest failing after PojoSerializerLoaderTest#542
Merged
Fix EventHandlerLoaderTest failing after PojoSerializerLoaderTest#542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
=========================================
Coverage 58.26% 58.26%
Complexity 222 222
=========================================
Files 46 46
Lines 1155 1155
Branches 149 149
=========================================
Hits 673 673
Misses 428 428
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godcrampy
approved these changes
May 8, 2025
trivenay
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: EventHandlerLoaderTest fails when run after PojoSerializerLoaderTest.
Description of changes: EventHandlerLoaderTest fails when run after PojoSerializerLoaderTest. This was caused by not resetting static fields that were modified by the tests inPojoSerializerLoaderTest after the tests are done.
Target (OCI, Managed Runtime, both): both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.