fix: update CognitoUserPoolPreTokenGenerationEventV2 response model#519
Merged
fix: update CognitoUserPoolPreTokenGenerationEventV2 response model#519
Conversation
… bump events to 3.15.0
darklight3it
approved these changes
Feb 4, 2025
maxday
reviewed
Feb 4, 2025
| 21 | ||
| distribution: corretto | ||
|
|
||
| # Install events module using Java 8 |
Member
There was a problem hiding this comment.
Have we verified that we need this change? Does CI still pass when we revert this modification?
Member
Author
There was a problem hiding this comment.
No it doesn't pass. The above CI runs are examples of experiments I tried to make it work with Java 21 (didn't work). The issue is that the event package has it's compiler set to Java 8, hence this looks like a forced move.
Member
|
LGTM! Thanks! 🎉, I just left a small comment |
maxday
approved these changes
Feb 4, 2025
ghost
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: #516
Description of changes:
CognitoUserPoolPreTokenGenerationEventV2to match the exprected contract from the docsv3.15.0since it's a breaking change.samplesto use the events library from current build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.