Repository navigation
fix(cli): unnecessary subprocess call on every run - #2083
Merged
Merged
Conversation
For determining the version of `aws-cdk-lib` that a user might be using, the CLI used to run a `node` subprocess on every invocation. Instead, we can do the same resolution inside the host `node` process, saving a subprocess call; saves ~80ms on every CLI invocation.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For determining the version of
aws-cdk-libthat a user might be using, the CLI used to run anodesubprocess on every invocation.Instead, we can do the same resolution inside the host
nodeprocess, saving a subprocess call; saves ~80ms on every CLI invocation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license