Skip to content

fix(aws-cdk): use recommended value for a single unconfigured flag #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FOWEPJF255 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(aws-cdk): use recommended value for a single unconfigured flag #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/commands/flags/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export class FlagOperations {
const cdkJsonContent = await fs.readFile(cdkJsonPath, 'utf-8');
const cdkJson = JSON.parse(cdkJsonContent);

if (flagNames.length === 1 && !params.safe && !params.all) {
if (flagNames.length === 1 && params.value !== undefined && !params.safe && !params.all) {
const boolValue = params.value === 'true';
cdkJson.context[String(flagNames[0])] = boolValue;
await this.ioHelper.defaults.info(`Setting flag '${flagNames}' to: ${boolValue}`);
Expand Down
34 changes: 34 additions & 0 deletions packages/aws-cdk/test/commands/flag-operations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,40 @@ describe('modifyValues', () => {
requestResponseSpy.mockRestore();
});

test('sets a single unconfigured flag to its recommended value', async () => {
const flagName = '@aws-cdk/aws-cloudfront:defaultViewerProtocolPolicyRedirectToHttps';
const flags: FeatureFlag[] = [{
module: 'aws-cdk-lib',
name: flagName,
recommendedValue: true,
userValue: undefined,
explanation: 'Redirect viewer requests to HTTPS by default',
}];
const cdkJsonPath = await createCdkJsonFile({});

setupMockToolkitForPrototyping(mockToolkit);

const requestResponseSpy = jest.spyOn(ioHelper, 'requestResponse');
requestResponseSpy.mockResolvedValue(true);

const options: FlagsOptions = {
set: true,
unconfigured: true,
recommended: true,
};

const flagOperations = new FlagCommandHandler(flags, ioHelper, options, mockToolkit);
await flagOperations.processFlagsCommand();

const updatedContent = await fs.promises.readFile(cdkJsonPath, 'utf-8');
const updatedJson = JSON.parse(updatedContent);

expect(updatedJson.context[flagName]).toBe(true);

await cleanupCdkJsonFile(cdkJsonPath);
requestResponseSpy.mockRestore();
});

test('sets all flags to recommended values', async () => {
const cdkJsonPath = await createCdkJsonFile({
'@aws-cdk/core:testFlag': false,
Expand Down
Loading