Skip to content

Remove duplicate E1155 and refine F3012 GetAtt locations - #469

Merged
satyakigh merged 2 commits into
mainfrom
fps
Oct 20, 2026
Merged

satyakigh merged 2 commits into
mainfrom
fps

Conversation

@satyakigh

@satyakigh satyakigh commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Suppress E1155 when the same concrete CloudWatch Logs name and condition scenario already produced the schema-grounded F3031 pattern diagnostic.
  • Keep other dedicated format findings unchanged; in particular, E1156 remains emitted so cfn-lint recall does not regress.
  • Preserve the authored YAML !GetAtt argument position and anchor typed-reference F3012 findings there while retaining the destination property path.
  • Regenerate corpus snapshots and all three cfn-lint comparison reports.

Validation behavior changes

Remove duplicate E1155

bad/F3031_log_group_name_dollar_brace.yaml previously emitted both F3031 and E1155 for the same invalid literal at Properties.LogGroupName. Both findings represented the same value, scenario, path, and name constraint.

The schema validator now tracks value/scenario pairs that emitted F3031 and suppresses E1155 only for that exact overlap. The retained finding is F3031 because the provider schema establishes the pattern violation. Unresolved deployment-time substitutions remain deferred, and other format-rule behavior is unchanged.

Checklist

  • For validation behavior changes, expected behavior is supported by CloudFormation evidence and all three engine selectors agree.
  • My code adheres to the CONTRIBUTING GUIDE and the repo code conventions and style in the code quality guide.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@satyakigh
satyakigh merged commit 3a95185 into main Oct 20, 2026
6 checks passed
@satyakigh
satyakigh deleted the fps branch October 20, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant