fix: replace scripting pattern blacklist with allowlist (CVE-2025-4318)#1198
Merged
Conversation
Event bindings become direct JSX expressions (onClick={value}), so dot-paths
like document.cookie would access browser globals at runtime. Restrict to
simple identifier regex (no dots) for event binding values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
+ Coverage 93.87% 93.90% +0.02%
==========================================
Files 150 150
Lines 6127 6137 +10
Branches 1838 1841 +3
==========================================
+ Hits 5752 5763 +11
+ Misses 357 356 -1
Partials 18 18
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
soberm
approved these changes
Jun 25, 2026
osama-rizk
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
filterScriptingPatternsregex blacklist with a strict allowlist inescapePropertyValue. The blacklist was trivially bypassed via indirect eval(0,eval)(...)— the regex/eval\s*\(/irequiresevaldirectly before(but indirect eval puts)between them.Fix
escapePropertyValuenow only permits strings matching valid JS identifiers or dot-notation paths:/^[a-zA-Z_$][a-zA-Z0-9_$]*(\.[a-zA-Z_$][a-zA-Z0-9_$]*)*$/This rejects ALL expression forms (parens, brackets, template literals, etc.) rather than trying to enumerate dangerous patterns.
Testing
References