harden secret-file denies: cover sed/awk/grep and other read vectors - #2
Merged
Merged
Conversation
The Claude Code permission denylist only enumerated cat/head/tail/base64 for secret files (.env, values*, *secret*, keys, ssh/aws/kube/gcloud, ...), so content readers like `sed`, `awk`, `grep`, pagers, editors, and copy commands bypassed it entirely — e.g. `sed -E '...' .env` read a secret straight through the sandbox. Generate the deny matrix (exfil command x secret glob) from two lists so coverage stays exhaustive and self-maintaining instead of hand-enumerating each command per file variant. Deny beats allow, so these override the blanket Bash(cat *)/Bash(grep *) allows. Concrete .env variants only (never a blanket .env.*), so .env.example/.sample/.template stay readable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Claude Code permission denylist only enumerated cat/head/tail/base64 for secret files (.env, values*, secret, keys, ssh/aws/kube/gcloud, ...), so content readers like
sed,awk,grep, pagers, editors, and copy commands bypassed it entirely — e.g.sed -E '...' .envread a secret straight through the sandbox.Generate the deny matrix (exfil command x secret glob) from two lists so coverage stays exhaustive and self-maintaining instead of hand-enumerating each command per file variant. Deny beats allow, so these override the blanket Bash(cat *)/Bash(grep ) allows. Concrete .env variants only (never a blanket .env.), so .env.example/.sample/.template stay readable.