Add scopehint on the category edit form

[thedotwriter]

Hi,

Here's a feature I really wanted from this module. I adapted the \AvS\ScopeHint\Plugin\ProductEavDataProviderPlugin for the category edit form. I tried to stay close to the module coding style.

Check it out and tell me what you think.

Cheers

[sprankhub]

Thanks a lot for working on this! I commented two minor things, which I found :) I wouldn't consider them necessary, though.

[thedotwriter]

Hi @avstudnitz, do you consider merging this feature or is it a no-go?

[rubenromao]

hi @thedotwriter
I would use the "constructor property promotion" introduced in PHP 8.0.
the properties are declared directly in the constructor which is a more concise and clean way to define class properties.
Example:

class CategoryFieldPlugin
{
    /**
     * @param StoreManagerInterface $storeManager
     * @param Registry $registry
     * @param CategoryRepositoryInterface $categoryRepository
     * @param Escaper $escaper
     */
    public function __construct(
        public readonly StoreManagerInterface $storeManager,
        public readonly Registry $registry,
        public readonly CategoryRepositoryInterface $categoryRepository,
        public readonly Escaper $escaper,
    ) {}

// rest of code

[thedotwriter]

Hi, thanks for checking this PR. This code is indeed quite old now. I will consider updating it if I ever get a feedback from the repo owner : p (@avstudnitz)

[rubenromao]

I see. Well done btw!
Hope that this is approved and merged soon.