Repository navigation
The README shows how cdclint is put together in one diagram - #30
Merged
Merged
Conversation
docs/diagrams/architecture.svg, embedded at the top of "What it checks": the five inputs read as files, the four readers in line with them, one model, the resolve step that matches every sink column to the source column it expects (the one accent, because that is where a dropped column is caught), the rules grouped by the question each answers, cdclint:ignore decisions, and the output with its exit code. Hand-written SVG in the style of the diagrams in avison9/warmbench, so it stays editable as text and renders the same on GitHub as anywhere else. Rejected: Mermaid. It renders natively on GitHub, but its automatic layout crossed edges and wrapped rule names at their hyphens, and the result did not read as cleanly. It lists replica-identity, which arrives in #29; merge this after #28 and #29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #28 and #29. The diagram lists
replica-identity, which arrives in #29.What changes
docs/diagrams/architecture.svg, a hand-written SVG in the style of the diagrams in avison9/warmbench. Top to bottom:cdclint:ignoredecisions;exit 1 fails the pull request.Verified
internal/. Every rule name is inengine.Ruleson replica-identity warns when a captured Postgres table has no replica identity #29.Rejected
Mermaid, which GitHub renders natively. Its automatic layout crossed edges and broke rule names at their hyphens, and it did not read as cleanly as this. The SVG is still plain text and can be edited.
For you
Look at it in the PR's rich diff of
README.mdbefore merging.