Repository navigation
INSTALLING.md installs the current release, and releasing now updates it - #26
Merged
Merged
Conversation
The release-archive examples for macOS, Linux and Windows, and the action's version pin example, still said 0.1.0. That is four releases behind: copying them installed a cdclint without --base, --disable or cdclint:ignore, which every later section of the README assumes. They now say 0.4.0, and all six archive URLs they build resolve. RELEASING.md gains the step that was missing: after the run, bring INSTALLING.md's version lines and docs/demo.tape (the README recording) up to the new tag. Rejected: resolving the latest version at install time through the GitHub API. It adds a network call and a JSON parse to a snippet meant to be read before it is run, and a pinned version is what a reader can check against checksums.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
INSTALLING.md: the release-archive examples for macOS (VERSION=), Linux (VERSION=) and Windows ($Version =), and the Action pin example (version:), go from 0.1.0 to 0.4.0. 0.1.0 is four releases behind and has no--base,--disableorcdclint:ignore.RELEASING.md: a new step after each release updates those lines and re-recordsdocs/demo.tape, so they don't go stale again.Verified
sudo), in a clean Debian container. It printscdclint 0.4.0.Rejected
Resolving the latest version at install time through the GitHub API. It adds a network call and a JSON parse to a snippet people read before running it. A pinned version is also what a reader can check against
checksums.txt.