Repository navigation
The diff rule's fix suggests a marker that also keeps the column out of the inventory - #24
Merged
Merged
Conversation
…of the inventory schema-before-connector told an author leaving a column out on purpose to write `-- cdclint:ignore schema-before-connector: <why>`. That marker works in the pull request and stops working at the merge: the rule only judges a change, and after the merge the same column is source-column-not-captured on every run, back in the inventory of columns nobody decided about. RefuseRadar's pinned script copied the hint into its own example and a review of #1142 there caught it. The fix now names both rules. Two corpus entries show the suggested marker working at both moments: ignore-marker-both-rules (with a base: acknowledged, and the second rule is not reported as covering nothing) and ignore-marker-both-rules-merged (no base: acknowledged as source-column-not-captured). Six expectations change by exactly the hint text. The README and the ignore package's example use the two-rule marker. Rejected: a warning for a marker that names only the diff rule. In the pull request it is a valid decision, and nothing distinguishes "only for now" from a mistake; the hint is where the author copies from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The fix line of
schema-before-connectornow suggests:It used to name only
schema-before-connector. That rule only judges a change, so after the merge the column came back assource-column-not-capturedon every run, which put a deliberate exclusion back in the inventory of undecided columns. RefuseRadar's script had copied the old hint, and the review of avison9/refuseradar#1142 caught it.Corpus
expected.txtfiles change by exactly the hint text. I edited them by hand first, and those six entries failed before the code changed.ignore-marker-both-rules, with a base: the hinted marker is acknowledged in the pull request, and the second rule is not reported as covering nothing.ignore-marker-both-rules-merged, no base: the same migration after the merge stays out of the inventory, acknowledged assource-column-not-captured.internal/ignorepackage doc use the two-rule marker.Verified
gofmt -l .is clean, andgo vet,go buildandgo test ./...pass (Docker, golang:1.25-bookworm).0 error(s), 0 warning(s), 162 info, unchanged.reportsgets the new hint. Pasting the hinted marker gives an acknowledgement and no warnings.Rejected
A warning for a marker that names only the diff rule. In the pull request that marker is a valid decision, and nothing tells "only for now" apart from a mistake. The hint is where authors copy from, so that is what this changes.