Repository navigation
Give the footer navbar the nav-footer class, matching prosilver - #79
Merged
Merged
Conversation
Follow-up to #64: the ID was renamed to nav-footer, but the list kept class="nav-main". No CSS or script targets either class, so rendering is unchanged; the markup now matches prosilver and pbwow3. Adds the missing 3.0.29 changelog entry for #64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #64 (fixed in 93e3832).
template/navbar_footer.html:class="nav-main linklist"becomesclass="nav-footer linklist", as in prosilver and pbwow3. Footer reuses id="nav-main", duplicating the header's ID #73 proposed this along with the ID change.contrib/CHANGELOG.md: adds the 3.0.29 entry for Duplicate ID nav-main: footer navbar reuses the header's ID #64, which 93e3832 didn't include. No version bump, since 3.0.29 isn't released yet.Why the class is safe to change: no stylesheet or script targets
.nav-mainor.nav-footeras a class. I checked PBTech's theme, templates andpbtech.js, prosilver's theme andforum_fn.js, and every installed extension. Rendering is unchanged.Checks:
npm run lintpasses.STYLE_ID=100 npm run validateon the local board finds nonav-errors. The 15 that remain are board content and extensions.🤖 Generated with Claude Code