Skip to content

SMPTE CFL - WIP#35

Open
cozdas wants to merge 25 commits intoautodesk-forks:mainfrom
cozdas:cozdas/SMPTE_CLF
Open

SMPTE CFL - WIP#35
cozdas wants to merge 25 commits intoautodesk-forks:mainfrom
cozdas:cozdas/SMPTE_CLF

Conversation

@cozdas
Copy link

@cozdas cozdas commented Jan 28, 2026

  • Exploratory work on SMPTE CLF format, currently supports reading the main new features only.

@cozdas
- Exploratory work on SMPTE CLF format, currently supports reading th…
90fb3ca 
…e main new features only.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas cozdas requested a review from doug-walker January 28, 2026 20:26
cozdas added 3 commits January 28, 2026 22:23
@cozdas
- Modifying the CLF writer to handle the SMPTE variant in a basic for…
845dba9 
…m. There are still some lose ends.

- The reader no longer allows the Version and xmlns attributes at the same time
- added --smpte switch to ociomakeclf tool.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- error out if version and xmlns are present at the same time, "only …
21a735d 
…when" the xmlns is an SMPTE version text.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Fix the tests
bf7b0dd 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas added 4 commits January 30, 2026 17:15
@cozdas
- Added ST2136-1:2024 compliant ID generation
991f458 
- Now enforcing the ID to be ST2136-1:2024 on read and write.
- now enforcing content of CLF version string if it's present in a SMPTE CLF.
- Added more tests

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- removing the st2136 schema file.
a41911e 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Adding the missing test file
c3e08ad 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Changed the ociomakeclf format specifiying argument from --smpte to…
f54a6f8 
… more generic --format %s

- For SMPTE variant, the write now writes v3 instead of ST2136-1:2024
- Re-worked the version loading logic to untangle it a bit.
- replaced the clf test data folder with the new folder structure and updated the existing test accordingly.
- TODO: add tests for the newly added clf files

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
doug-walker reviewed Feb 4, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some initial comments. I'm wondering if it would be a worthwhile simplification to not have two separate formats.

cozdas added 2 commits February 5, 2026 10:44
@cozdas
- removing the okld smpte test files
d1bd6cb 
- Adding separate element and attribute Id's
- Adding warning comments to few misleading elements which break the general design.
- Simplifying the SMPTE version handling.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Backing up from using separate file formats for Academy and SMPTE CLF
8440fa5 
- updating the test files accordingly
- Some cleanup

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 5, 2026
View reviewed changes
cozdas
cozdas commented Feb 6, 2026
View reviewed changes
@cozdas
- Add format restriction to version string checks.
07fed48 
- General cleanup, hopefully tests will be happy now.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
Fix the tests
614a22f 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas added 2 commits February 6, 2026 15:49
@cozdas
- Adding bare-bone tests exercising the newly added clf files.
163308d 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- minor improvement to the tests
c12e375 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
doug-walker reviewed Feb 7, 2026
View reviewed changes
cozdas added 2 commits February 7, 2026 22:19
@cozdas
- Added GroupTransform::GetCacheID() function to generate UUID based …
60bf463 
…on the group ops. It uses a raw config to create the ops. The generated Id matches the id attribute that the CTF writer generates.

- createclf tool is updated to have the generateid flag
- added experimental STRIP_NAMESPACES control flag to CTF parser. When set to true, all the name spaces are stripped before parsing the elements. This makes the parser understand elements with name spaces (e.g. clf:ProcessList). Parser can still be confused if multiple names paces are used though.
- CTF TransformWriter::generateID() now generates the id always in the SMPTE format
- Added few more tests
- general cleanup

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Fix the test: we can now load the namespaces.clf.
6f34f24 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
doug-walker reviewed Feb 9, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for leading you in the wrong direction on the GroupTransform::getCacheID!

And sorry that this is turning into a bigger project than anticipated. Here are some other comments.

doug-walker
doug-walker reviewed Feb 9, 2026
View reviewed changes
cozdas added 6 commits February 9, 2026 17:34
@cozdas
- Undo adding getCacheID() to group transform
83bae93 
- ociomakeclf now uses optimized processors's cache ID to populate Id Element.
- make sure that Processor always generate UUID as the cacheID, even when it has zero ops.
- misleading CTFReaderTransform::getOps() function name is changed to getOpDataVec()

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- various fixes
1c3751b 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Name space stripping is now compile-time enabled all the time but n…
c647d35 
…ow there's a switch to turn that off during parsing. Currently the name space stripping it turned off during the info element parsing.

- all of the encountered input and output descriptors are now collected just like the description element. collecting the language attribute will need re-working the whole metadata structure, which can be the next step.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Make the picky compilers happy.
5b95961 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- Signature.clf test file is removed until its finalized.
cf788cd 
- CLF reader now allows non-compliant Id elements, but with a warning. Writer still throws.
- More tests added
- General cleanup.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
@cozdas
- typo fixes
e71ac36 
- remove id attr from the broadcast clf (unbreak the build)
- Expand the tests

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas
cozdas commented Feb 11, 2026
View reviewed changes
@cozdas
- Make the descriptor parsers robust for receiving the strings in pie…
65fb7fb 
…ces.

Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
cozdas
cozdas commented Feb 11, 2026
View reviewed changes
doug-walker
doug-walker reviewed Feb 11, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Here are the few remaining items I found.

doug-walker
doug-walker reviewed Feb 11, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where I recommend inserting the new tests in FileFormatCTF_tests.cpp.

doug-walker
doug-walker reviewed Feb 11, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I un-resolved a two items in the conversation above:

  1. Add the requested process_list_conflicting_versions.ctf and test.
  2. Add the requested process_list_higher_ns_version.clf and test.

But the highest priority is to start the PR with whatever we have as soon as possible. Remaining items could come in additional commits.

src/OpenColorIO/fileformats/ctf/CTFTransform.cpp
if (!idEl.empty())
{
m_formatter.writeContentTag(METADATA_INPUT_DESCRIPTOR, inputDesc);
if (m_subFormat == SubFormat::FORMAT_CLF && !ValidateSMPTEId(idEl))
Copy link

@doug-walker doug-walker Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove the subformat check, even if we write it in CTF, it should validate.

@cozdas
- Addressing the review comments.
06aa892 
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
doug-walker approved these changes Feb 11, 2026
View reviewed changes
Copy link

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME, nice work! Please proceed with the public PR.

Trying to change the line endings of this file back to CRLF
c5e444f 
Signed-off-by: ozdasc <cuneyt.ozdas@autodes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doug-walker doug-walker doug-walker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cozdas @doug-walker