Open
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit 08a3adf) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit fadef86) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit 008ad27) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit cbc0f0e) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit 9871ef4) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit 914b2f0) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com> (cherry picked from commit f60e990) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
cozdas
reviewed
Aug 6, 2025
| size_t getNumEntries() const noexcept; | ||
|
|
||
| /// Get the index from the rule name. | ||
| /// Get the index from the rule name. Throws if the rule is not found. |
There was a problem hiding this comment.
Good catch for missing documentation for what happens when the input is not found.
But this behavior is different from other similar getIndex...() function we have. They return either -1 or size_t(-1) depending on the return type. Maybe we should change this function's behavior to return -1 too (which I think is more appropriate for a function which can be used to query the existence. Easier to use on the client-side too)
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.