Conversation
…fn-114.12) Land 10-entry curve deny-list across all 7 clippy.toml files (workspace + 6 per-crate). Add scripts/check-clippy-sync.sh generator to verify files stay in sync. Sanctioned module-level allows on auths-crypto key_ops and ring_provider (permanent). Caller crates carry crate-level #![allow(clippy::disallowed_methods)] at lib.rs, tests/integration.rs, benches, fuzz targets, and binary roots. PKCS8 invariant harness at crates/auths-crypto/tests/cases/pkcs8_roundtrip.rs: 4 positive cases (Ed25519/P-256 roundtrip + parser parity + garbage reject) plus 2 #[ignore]-d hazard demonstrations with UNGATE IN fn-114.18 markers. Main stays green; --include-ignored exposes S3/S4 silent-corruption vector.
…ion helpers (fn-114.13/14/16) TypedSignerKey in auths-crypto: curve-tagged signer with from_pkcs8, from_parts, from_seed, sign, to_pkcs8 (curve-aware replacement for build_ed25519_pkcs8_v2 + encode_seed_as_pkcs8), cesr_encoded_pubkey, public_key/seed/curve accessors. Fields private to prevent callers from grabbing raw bytes and re-introducing curve-less dispatch. RotationSigner kept as transitional type alias
…y (fn-114.17/18/19) S2 (Rekor): pubkey_to_pem takes &DevicePublicKey and returns Result<String, LogError>. Unknown curves produce a typed error instead of a base64-wrapped bogus PEM that Rekor would log but no verifier could match. build_dsse becomes fallible
…0/21) Acceptance #7: auths_id::attestation::verify::verify_with_resolver body DELETED; file retained as a documentation-only module pointing at the canonical auths_verifier::verify_with_keys. auths_sdk::attestation-s re-export removed. 3 callers migrated: - auths-cli/commands/device/authorization.rs inline resolve + verify - auths-cli/commands/org.rs x2 via verify_attestation_via_resolver helper All three sites now use auths_sdk::identity::DidResolver to resolve issuer DIDs, construct typed DevicePublicKey via decode_public_key_bytes, and block_on auths_verifier::verify_with_keys. ring::signature::ED25519 hardcoding eliminated from auths-id Pairing-protocol (token.rs, response.rs): curve dispatch by peer pubkey length. Ed25519 (32 bytes) routes through ring; P-256 (33/65 bytes) through RingCryptoProvider::p256_verify. Cross-curve pairing supported per fn-114 Open Question 6 resolution. auths-pairing-protocol Cargo.toml enables auths-crypto native feature for RingCryptoProvider access
…/36) Hard break on on-disk formats per epic Launch posture: - PinnedIdentity.curve: CurveType (required field, no default) - RootsFile version bumped 1 -> 2; v1 rejected with typed error - Old pin/roots files fail to deserialize; users re-author Construction sites at trust/resolve.rs (TOFU + rotation update), commands/trust.rs, commands/device/verify_attestation.rs infer curve via CurveType::from_public_key_len at the ingestion boundary. CryptoProvider::verify_p256 trait method with default UnsupportedTarget impl. WebCryptoProvider::verify_p256 uses SubtleCrypto.verify(ECDSA, P-256, SHA-256) via wasm-bindgen-futures. Accepts 65-byte uncompressed SEC1; decompresses 33-byte compressed via the p256 crate when native feature is on
Per CESR spec: 1AAI = P-256 verification key (33 bytes compressed SEC1); 1AAJ = P-256 signature (64 bytes). Repo emitted 1AAJ for verkeys which external CESR-conformant tools (keripy, Sigstore CESR) would reject or misinterpret. Emitter sites flipped to 1AAI: - auths-crypto TypedSignerKey::cesr_encoded_pubkey (Commit 2) - auths-id::keri::inception P-256 inception event - auths-keri KeriPublicKey::cesr_prefix Parser (KeriPublicKey::parse) retains tolerant 1AAI/1AAJ acceptance so pre-flip on-disk identities still deserialize during migration window. Test assertions (auths-id/tests, auths-sdk rotation) updated
…tors + switch TypedSignerKey callers to public_key() accessor, clippy
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Auths Commit Verification
Result: ✅ 1/127 commits verified (126 skipped) |
…verify fixtures for v2+curve, pass valid pubkey in rekor network test
Auths Commit Verification
Result: ✅ 1/127 commits verified (126 skipped) |
…g-gate to clear unused_mut lint
Auths Commit Verification
Result: ✅ 1/127 commits verified (126 skipped) |
…entities were producing Ed25519-signed garbage)
Auths Commit Verification
Result: ✅ 1/127 commits verified (126 skipped) |
…ver auto-detected env
Auths Commit Verification
Result: ✅ 1/127 commits verified (126 skipped) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.