Skip to content

Make usable with existing clusters#3

Merged
mologie merged 5 commits intomasterfrom
non-temporary-clusters
Mar 3, 2026
Merged

Make usable with existing clusters#3
mologie merged 5 commits intomasterfrom
non-temporary-clusters

Conversation

@minus7
Copy link
Copy Markdown
Member

@minus7 minus7 commented Feb 19, 2026

Add a Cluster abstraction and the ability to instantiate a postgres
daemon from an existing cluster directory. Also add that feature to the
wrapper tool.

Cluster and Instance aren't integrated with each other yet, but this is a big step to make running a postgres daemon possible from a Go program, for example when you want to run your software in a container including the database.

@minus7 minus7 force-pushed the non-temporary-clusters branch from 9862e1c to dfca83d Compare February 20, 2026 21:45
@minus7 minus7 force-pushed the non-temporary-clusters branch 2 times, most recently from b9be2e8 to 3a1938e Compare March 2, 2026 11:38
@mologie mologie force-pushed the non-temporary-clusters branch from 3a1938e to 53d33a5 Compare March 2, 2026 15:01
@mologie
Copy link
Copy Markdown
Contributor

mologie commented Mar 2, 2026

I moved the Cosmetics for imports to be the first commit (and re-applied it via Goland for all files), and then added an intermediate commit that just moves the postgres type to make reviewing of the actual implementation easier. Final code is unchanged. Please reset to 3a1938e if you don't like this. (Still reviewing otherwise, mostly LGTM!)

Comment thread tmppg.go Outdated
Comment thread tmppg.go Outdated
Comment thread tmppg.go Outdated
Comment thread internal/errutil/errors.go
Comment thread cluster.go
@minus7 minus7 force-pushed the non-temporary-clusters branch from 3e6639f to a22c4ca Compare March 3, 2026 14:52
minus7 added 2 commits March 3, 2026 16:27
Add a Cluster abstraction and the ability to instantiate a postgres
daemon from an existing cluster directory. Also add that feature to
the wrapper tool.
SIGTERM causes postgres to wait for open connections to disconnect
("smart shutdown"), while SIGINT shuts down immediately.
@minus7 minus7 force-pushed the non-temporary-clusters branch from a22c4ca to bff0ed4 Compare March 3, 2026 15:27
@mologie mologie merged commit 1a16bf4 into master Mar 3, 2026
@mologie mologie deleted the non-temporary-clusters branch March 3, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants