Add optionalToken parameter to middleware#342
Draft
magnusburton wants to merge 2 commits intoauth0:masterfrom
Draft
Add optionalToken parameter to middleware#342magnusburton wants to merge 2 commits intoauth0:masterfrom
magnusburton wants to merge 2 commits intoauth0:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I thought about adding a parameter to allow for tokens to be read, while still allowing tokens to be retired, expired, invalid, or non existent without anything being thrown. If a valid token can be decoded, it'll be returned. The PR does not break anything as it's false by default, so existing implementations will still work.
References
I figured I'd do this due to my own personal need, as well as a couple of discussions within this repository, #194
Testing
I've not yet got around to add tests. If someone would like to contribute with some, please do!
Checklist