fix(auth0-express): stop leaking internal error detail from handlers#26
Open
frederikprijck wants to merge 1 commit into
Open
fix(auth0-express): stop leaking internal error detail from handlers#26frederikprijck wants to merge 1 commit into
frederikprijck wants to merge 1 commit into
Conversation
Route handler failures through next(error) instead of echoing error.name/message/error_description to the client, so Express error middleware owns the response and internal detail is not disclosed. SECURITY: SDK-4 — verbose error messages (CWE-209).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The auth handlers echoed
error.name/error.message(anderror.cause.error_description) verbatim in HTTP responses, leaking internal/library error detail useful for probing the auth flow.Changes
All four handlers (login, callback, logout, backchannel-logout) now route failures through Express's
next(error)instead of writing error detail to the response. Express's error middleware owns the response; the SDK no longer authors the leak. Handler signatures gained anextparam, threaded through the router.Tests
Handler + index specs updated to the sanitized contract. The error-leak tests run under
NODE_ENV=production(matching Express's real sanitization behavior) and were verified via a leak-revert to genuinely fail if a handler leaks. auth0-express suite: 185/185 pass.