fix(auth0-express): reserve OIDC Request-Object params in login handler#25
Open
frederikprijck wants to merge 1 commit into
Open
fix(auth0-express): reserve OIDC Request-Object params in login handler#25frederikprijck wants to merge 1 commit into
frederikprijck wants to merge 1 commit into
Conversation
Adds request, request_uri, id_token_hint, claims and response_mode to the reserved OAuth params so a crafted login link cannot forward them to /authorize. prompt and login_hint remain forwardable by design. SECURITY: SDK-2 — widened authorize-request surface (CWE-601/CWE-235).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterAuthorizationParamsforwarded any query param tostartInteractiveLogin'sauthorizationParamsunless reserved. The reserved set did not include the OIDC Request-Object params, so a crafted login link (/auth/login?request_uri=https://attacker/obj) could submit a Request Object to/authorizecarrying its own parameters.Changes
Added
request,request_uri,id_token_hint,claims,response_modetoRESERVED_OAUTH_PARAMS.promptandlogin_hintare intentionally left forwardable — integrators commonly pass them on purpose. A guard test locks that in.Tests
login-handler.spec.ts: new blocklist cases for the five params + a guard thatprompt/login_hintstill forward. Suite green.