Skip to content

fix: keep scope case when appending the openid scope #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmathew92 merged 2 commits into from
Oct 22, 2026
Merged

fix: keep scope case when appending the openid scope #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f37049
fix: keep scope case when appending the openid scope
RaphaelFakhri Oct 21, 2026
65bea0d
fix: match openid scope case-sensitively
RaphaelFakhri Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions auth0/src/main/java/com/auth0/android/request/internal/OidcUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.auth0.android.request.internal

import java.util.*

/**
* Small utility class to handle OpenID Connect conformance
*/
Expand All @@ -19,8 +17,7 @@ internal object OidcUtils {
*/
fun includeRequiredScope(scope: String): String {
val existingScopes = scope.split(" ")
.map { it.toLowerCase(Locale.ROOT) }
return if (!existingScopes.contains(REQUIRED_SCOPE)) {
return if (existingScopes.none { it == REQUIRED_SCOPE }) {
(existingScopes + REQUIRED_SCOPE).joinToString(separator = " ").trim()
} else {
scope
Expand Down
12 changes: 12 additions & 0 deletions auth0/src/test/java/com/auth0/android/authentication/ParameterBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,18 @@ public void shouldSetRefreshToken() {
assertThat(parameters, hasEntry("refresh_token", DEVICE));
}

@Test
public void shouldKeepScopeCaseWhenAddingRequiredScope() {
Map<String, String> parameters = builder.setScope("profile read:Messages").asDictionary();
assertThat(parameters, hasEntry("scope", "profile read:Messages openid"));
}

@Test
public void shouldAddRequiredScopeWhenOnlyAnotherCaseIsPresent() {
Map<String, String> parameters = builder.setScope("OpenID profile").asDictionary();
assertThat(parameters, hasEntry("scope", "OpenID profile openid"));
}

@Test
public void shouldSetScopeWithOfflineAccess() {
Map<String, String> parameters = builder.setScope(ParameterBuilder.SCOPE_OFFLINE_ACCESS).asDictionary();
Expand Down
Loading