Repository navigation
feat(authentication): add organization parameter to resetPassword - #1038
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthrough
ChangesPassword reset organization support
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Sequence Diagram(s)sequenceDiagram
participant Client
participant AuthenticationAPIClient
participant PasswordResetEndpoint
Client->>AuthenticationAPIClient: resetPassword(email, connection, organization)
AuthenticationAPIClient->>PasswordResetEndpoint: Send reset parameters including organization when provided
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@EXAMPLES.md`:
- Around line 1820-1827: Update the Kotlin example around the
AuthenticationException catch block to use the valid Throwable method name on e;
replace the current printStacktrace call with the standard printStackTrace
invocation so the snippet compiles when copied. Keep the rest of the
resetPassword example unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 06be18f4-3506-46e7-9570-6137fe5ff6d0
📒 Files selected for processing (3)
EXAMPLES.mdauth0/src/main/java/com/auth0/android/authentication/AuthenticationAPIClient.ktauth0/src/test/java/com/auth0/android/authentication/AuthenticationAPIClientTest.kt
d645f0b to
efa2682
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
Adds an optional
organizationparameter toAuthenticationAPIClient.resetPassword, sent as theorganizationkey in thedbconnections/change_passwordrequest body.When set, Auth0 associates the password reset request with that organization, which makes
organization_idandorganization_nameavailable in the reset redirect URL and as variables in customized email templates.authentication .resetPassword("info@auth0.com", "my-database-connection", "org_abc123") .start(callback)Additive only. The parameter defaults to
null; when absent the request body is byte-identical to today's. No existing behaviour changes.Test plan
./gradlew testReleaseUnitTest jacocoTestReleaseUnitTestReport lintRelease --continue— BUILD SUCCESSFULauth0:compileReleaseKotlinpasses explicit API mode (strict)resetPasswordtests pass unmodified — confirms backward compatibility@JvmOverloads2-arg bridge confirmed present viajavap