Repository navigation
hk: test later links of the M5 depth compression chain - #97
Merged
Merged
Conversation
The M5 depth eligibility test only put external memory as the first chain link, so a walk that stopped after one link still passed. Check a format list followed by external memory, and by the WSI marker, as refusals, and the format list alone as eligible. hk_g17p_compression_test: 4078 checks pass; the same test fails when the depth walk stops after its first link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a test gap chriskearney noted in his review of omacom#19: a mutant that truncates the M5 depth chain walk after its first link survived the host suite. The depth test now checks a format list followed by external memory, and by the WSI marker (both refused), and the format list alone (eligible). Test-only.
hk_g17p_compression_test: 4078 checks pass, and the same test fails when the depth walk stops after its first link.