Skip to content

selftests: apple-dcp: give the backlight fixtures the DAC fade fields #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanTheTide merged 1 commit into from
Nov 5, 2026
+9 −4
Merged

selftests: apple-dcp: give the backlight fixtures the DAC fade fields #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tools/testing/selftests/drivers/gpu/apple-dcp/desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ def brightness_takeover(root):
struct apple_dcp {
int fw_compat;bool quiescing;
struct {int iomfb_method_profile;} hw;
struct {u32 maximum,nits,dac;bool update;struct backlight_device *bl_dev;} brightness;
struct {u32 maximum,nits,dac;bool update;struct backlight_device *bl_dev;
u32 level,fade_from,fade_to;bool fading;unsigned long fade_start;int fade_work;} brightness;
struct {bool lock;struct dcp_backlight_state state;unsigned long fade_start;
int fade_work;void (*kick)(struct apple_dcp *);} backlight;
struct {bool inherited_brightness_valid;u32 inherited_brightness;} *desktop;
Expand Down Expand Up @@ -288,6 +289,10 @@ def brightness_takeover(root):
static int drm_modeset_lock_single_interruptible(int *p) {(void)p;assert(false);return 0;}
static void drm_modeset_unlock(int *p) {(void)p;assert(false);}
static int dcp_backlight_update(struct apple_dcp *d) {(void)d;assert(false);return 0;}
/* The DAC fade (M1/M2 firmware) never runs on the desktop panel. */
#define system_freezable_wq NULL
static bool dcp_dac_fade_starts(struct apple_dcp *d,u32 nits) {(void)d;(void)nits;assert(false);return false;}
static void mod_delayed_work(void *q,int *w,unsigned delay) {(void)q;(void)w;(void)delay;assert(false);}
''' + functions + r'''
int main(void)
{
Expand Down Expand Up @@ -835,7 +840,7 @@ def brightness_notifications(root):
struct backlight_device {struct {int kobj;} dev;struct {u32 brightness;} props;};
struct apple_dcp {
int fw_compat;bool quiescing,crashed;
struct {struct backlight_device *bl_dev;} brightness;
struct {struct backlight_device *bl_dev;int fade_work;} brightness;
struct {bool lock;struct dcp_backlight_state state;struct work_struct notify_work;int fade_work,retry_work;} backlight;
struct {struct dcp_backlight_swap backlight;} *desktop;
};
Expand Down Expand Up @@ -871,10 +876,10 @@ def brightness_notifications(root):
dcp_backlight_desktop_finish(&d,9,true,false);assert(events==1);
d.quiescing=true;dcp_backlight_notify(&d);assert(events==1);
d.quiescing=false;d.fw_compat=1;dcp_backlight_notify(&d);assert(events==1);
dcp_backlight_stop(&d);assert(!cancelled && delayed_cancelled==2);
dcp_backlight_stop(&d);assert(!cancelled && delayed_cancelled==3);
d.fw_compat=5;dcp_backlight_notify_release(&d);
assert(!d.brightness.bl_dev && cancelled==1);dcp_backlight_notify(&d);assert(events==1);
dcp_backlight_stop(&d);assert(cancelled==2 && delayed_cancelled==4);
dcp_backlight_stop(&d);assert(cancelled==2 && delayed_cancelled==6);
return 0;
}
'''
Expand Down