Skip to content

iommu/apple-dart: refuse v2.2 DARTs whose reg misses the exception records #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanTheTide merged 1 commit into from
Nov 5, 2026
Merged

iommu/apple-dart: refuse v2.2 DARTs whose reg misses the exception records #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions drivers/iommu/apple-dart.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4302,6 +4302,19 @@ static int apple_dart_probe(struct platform_device *pdev)
goto err_clk_disable;
}

/*
* v2.2 moved the exception bitmap to 0x4000 and the per-stream
* exception records to 0x8000. A node whose reg stops short of them
* would fault on the first exception read during reset.
*/
if (dart->hw->type == DART_T8110 && dart->version >= 0x0202 &&
resource_size(res) < DART_T8110_ERR_SID(dart->num_streams)) {
ret = dev_err_probe(dev, -EINVAL,
"MMIO region %pR too small for v2.2 exception records (need %#x); fix the DT reg\n",
res, DART_T8110_ERR_SID(dart->num_streams));
goto err_clk_disable;
}

ret = apple_dart_read_remaps(dart);
if (ret)
goto err_clk_disable;
Expand Down