Repository navigation
Conversation
The T6050 profile registers input, power and hwmon only, so a T6050 kernel that owns the machine (J775D, booted on the hardware) had no SMC restart or power-off and no RTC: poweroff halted Linux and left the machine on. macsmc-reboot and macsmc-rtc join the T6050 profile as cells registered only where the device tree has their child node, the rule the pcIO outputs and the second GPIO bank already follow; those blocks become one table and one helper. A T6050 device tree without reboot or rtc children (an APIF guest's) registers exactly what it did. Other SMCs are unchanged: the same cells in the same order. The registration-failure messages now name the cell. Signed-off-by: Jeff Queisser <funkzy@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing: carried in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#479's T6050 profile registers the input, power and hwmon cells only. That fits the APIF guest. A T6050 kernel that
owns the machine (the M5 Ultra Mac Studio, J775D, with Linux on the hardware) then has no SMC restart or power-off
and no RTC:
poweroffhalted Linux and left the machine on. This registersmacsmc-rebootandmacsmc-rtconT6050 too, but only where the device tree has their child node, the rule the pcIO outputs and the second GPIO bank
already follow.
What it changes
helper: a cell is registered when its child node exists.
Testing (J775D, M5 Ultra)
The kernel: our J775D series (integration/aurora's lineage, as on the Studio every day) with this PR's code and
that of the other T6050 PRs sent with it in place of the series' own forms, booted once on 2026-11-02 and restarted
through the SMC at the end. The same code is in the series kernel the machine boots by default.
requests via SMC", "macsmc-rtc: registered as rtc0", and the system clock set from it at 1.22 s.
"Issuing restart (phra)"), and the machine came back on its default kernel.
Not tested
poweroffon this branch's own build: it turns the Studio off, and the Studio is remote. The same code (thiscommit's patch, on our series with mfd: macsmc: Support T6050 power and pcIO consumers #479) powered the Studio off once on 2026-11-02: ping stopped 4 s after
systemctl poweroffand stayed down until the power button was pressed, and the RTC kept time through the offstate.
Dependencies
#479 (
t6050/smc). The J775D DT with the reboot and rtc children comes with the J775D board.For dj
Is #479 the right place for this, or would you rather take it after #479 reaches aurora-wip?