Repository navigation
selftests: apple-dcp: follow the PMP auxiliary buffer in ordered-rx - #598
Merged
RyanTheTide merged 1 commit intoOct 30, 2026
Merged
Conversation
#472 added a T6050 PMP registry-v2 path to apple_rtkit_rx_work(): endpoint 7 now goes to apple_rtkit_pmp_aux_rx() when rtk->pmp_registry_v2 is set. The ordered-rx fixture extracts apple_rtkit_rx_work(), but its struct apple_rtkit has no such field and nothing defines the new handler, so the group stopped compiling and the apple-dcp host suite went from 80/80 to 79/80 on integration/aurora. Give the fixture struct apple_rtkit the field and stub the handler the way the CoreAnalytics one is stubbed, as unreachable in this fixture. No assertion changes. The edid group also still passes on the tree before #472, where the stub is unused. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The apple-dcp host selftests (
tools/testing/selftests/drivers/gpu/apple-dcp/run.py) went from 80/80 to 79/80 on integration/aurora. Group 29,ordered-rx, no longer compiles.It came in with #472 (the shared T6050 APIF platform base). That PR gave
apple_rtkit_rx_work()indrivers/soc/apple/rtkit.ca registry-v2 branch for endpoint 7:if (rtk->pmp_registry_v2) apple_rtkit_pmp_aux_rx(...). Theordered-rxfixture extractsapple_rtkit_rx_work()into a host program. Its ownstruct apple_rtkithas nopmp_registry_v2field, and nothing definesapple_rtkit_pmp_aux_rx():The kernel code is fine. Only the host fixture fell behind.
The fix
The fixture's
struct apple_rtkitgets the field, andrun.pystubsapple_rtkit_pmp_aux_rx()as unreachable, the same way it already stubsapple_rtkit_coreanalytics_rx()for that endpoint. No assertion changes.Tested (buildbox, clang 22)
run.pyon this branch: 80/80.run.pyon integration/aurora 695d974 without this change: 79/80, withordered-rxfailing as above.run.py --group edidon the tree before firmware: Add the shared T6050 APIF platform base #472 (78d459d^1) with this change applied: 4/4. On older trees the stub is simply never used.This is a test-only change, so it needs no hardware test.
🤖 Generated with Claude Code