Skip to content

pmdomain: apple: IRQ-safe PMP report entries #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fbalazsy wants to merge 2 commits into from
Closed

pmdomain: apple: IRQ-safe PMP report entries #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f231fb
dt-bindings: power: apple: add apple,irq-safe to the PMP report entries
fbalazsy Oct 25, 2026
c254057
pmdomain: apple: pmp-report: IRQ-safe entries
fbalazsy Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Documentation/devicetree/bindings/power/apple,t8140-pmp-report.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ patternProperties:
holds this entry's device ID, instead of by reg. Only valid on a
report whose PMP the host starts.

apple,irq-safe:
type: boolean
description:
The entry is the parent of IRQ-safe PMGR power states and is
switched with interrupts disabled. Setting the state takes a
spinlock and polls the acknowledgment atomically.

required:
- compatible
- reg
Expand Down
7 changes: 7 additions & 0 deletions drivers/pmdomain/apple/pmp-report.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1473,6 +1473,13 @@ static int apple_pmp_report_entry_probe(struct platform_device *pdev)

ent->genpd.power_on = apple_pmp_report_entry_power_on;
ent->genpd.power_off = apple_pmp_report_entry_power_off;
/*
* An entry that is the parent of PMGR power states (which are IRQ safe)
* must be IRQ safe too. Setting the state takes a spinlock and polls
* the acknowledgment atomically, so it may be called with IRQs off.
*/
if (of_property_read_bool(node, "apple,irq-safe"))
ent->genpd.flags |= GENPD_FLAG_IRQ_SAFE;

ret = pm_genpd_init(&ent->genpd, NULL, true);
if (ret) {
Expand Down