Repository navigation
net: apple: Add N1 firmware and ACIPC transport over APIF PCI - #250
Closed
DjDeveloperr wants to merge 1 commit into
Closed
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
Describe firmware profile inputs in DT instead of dispatching by machine name. Require stopped ROM ownership and the supported APIF host reset layout. Remove manual bootstrap controls and diagnostic success logging. Check firmware ranges and per-function resource ownership, verify DMA shutdown before releasing backing memory, and join bootstrap on removal. Keep Wi-Fi and Bluetooth consumers as separate additions. Signed-off-by: Dj <hey@djdev.me>
This was referenced Oct 11, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the N1 Control firmware/PCI/ACIPC transport separately from its Wi-Fi and Bluetooth consumers. Firmware name, packed platform identifier and protocol profile come from the Control PCI DT node, without machine-name dispatch or bundled firmware/calibration data.
Require the supported preinitialized APIF host/reset layout and stopped ROM personality. Remove the manual bootstrap debugfs controls, diagnostic DMA allocation, firmware dump interfaces and success logging. Keep PCI-function DMA ownership distinct, validate BAR/config apertures and FTAB ranges, check config publication writes, and verify bus-master shutdown before releasing backing memory. Failed link transitions or uncertain shutdown retain published DMA. Only lock contention can retry a boot phase; remove cancels and joins the worker. Suspend refuses an incomplete bootstrap.
This PR starts the shared firmware and establishes its contexts. The radio consumers are separate follow-ups. The host reset also requires exclusive ownership with no retained firmware streams on the DART unit; this driver does not discard those streams. The new producer metadata must be supplied before migrating an existing guest tree.
Validation: native arm64 linked transport objects with the real Kconfig enabled, binding validation, production-function FTAB/DMA-shutdown host tests, and whitespace checks passed. Hardware qualification of the cleaned series remains pending. No GPU changes.
Depends on the APIF PCI reset interface from #242; stacked on #249 to keep review order linear.