Repository navigation
Conversation
The PMP firmware keeps running DCS and fabric DVFS while the system is up. The J704 ps_pmp domain is not marked always-on, so genpd gates it at s2idle and the PMP takes an SError in its own firmware. The J813 got the same fix in ceaab64 ("arm64: dts: apple: t8142-j813: Keep the PMP power domain on"); T8132 and T8140 mark ps_pmp always-on too. Tested on J704 with the same property on an earlier tree: the first s2idle no longer crashes the PMP, and the machine wakes with the display, Wi-Fi and Bluetooth back. Signed-off-by: Dmitriy <noc@pimk.in> Assisted-by: LLM
The J704's MTP firmware offers the trackpad's haptic engine as interface 4 "actuator", as on the M5 MacBook Airs: Initializing comm interface <4- "actuator"> Without a node for it, dockchannel-hid ignores the interface and the click stays firmware-driven, with no Force Touch stage. Describe it as d2db3f8 ("arm64: dts: apple: t8142-j813-j815: Add the trackpad actuator") does for the Airs. Signed-off-by: Dmitriy <noc@pimk.in> Assisted-by: LLM
The J704 ADT's mcc,t8142 node matches the J815's: one AMCC (amcc-count 1, amcc-reg-idx 1), amcc-plane-enable-mask 0xf, reg[1] at 0x220000000 spanning the four planes 0x40000 apart. Enable the t8142.dtsi node from 167e403 ("arm64: dts: apple: t8142: Add the MCC (system level cache) node"). The boot loader turns allocation on; the driver checks it and flushes the cache on shutdown. Signed-off-by: Dmitriy <noc@pimk.in> Assisted-by: LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three DT-only follow-ups to #1231 that bring the J704 in line with what the M5 Airs got this week. The drivers are already in integration/aurora; each change mirrors the Air commit for the same die.
ps_pmpat s2idle under the running PMP firmware. The J704 hit exactly this on an earlier tree: the PMP took an SError on the first s2idle.Initializing comm interface <4- "actuator">); without the node the click stays firmware-driven and there is no Force Touch stage.mcc,t8142matches the J815's: one AMCC,amcc-plane-enable-mask0xf, reg[1] at 0x220000000 with four planes 0x40000 apart. If the loader has not enabled the ways, the driver refuses to bind and changes nothing.Tested on: the PMP change on J704 with the same property on an earlier tree (one clean s2idle and wake, display, Wi-Fi and Bluetooth back). The actuator and the MCC are not tested on the J704 yet; the PR stays a draft until they are.
scripts/dtc/apple-dt-check.shagainst a34d26c: 137 DTBs, no new warnings and none removed. The J704 keeps only thedisp0_piodmaalias warning it already had.Prepared with Claude Opus 5.5.