Repository navigation
drm/apple: dptxep: record the tile hint of a tunneled sink on 26.6 - #1818
Merged
DjDeveloperr merged 2 commits intoNov 13, 2026
Merged
DjDeveloperr merged 2 commits into
DjDeveloperr merged 2 commits into
Conversation
On the desktop 26.6 firmware, SET_TILED_DISPLAY_HINTS goes to the dual-pipe allocation (dcp_peer_hints_26_6()) and returns from there. That path never records the tile the port carries, so dptxport[0].tile_hint stays false and a tiled display behind a Thunderbolt tunnel can never take its second tile on dpin1 (dcp_tb_split_*): the split waits for the hint, then gives up. The Studio Display on Thunderbolt 3 is such a sink: two 2560x2880 tiles, 5120 wide, which is under DCP_DESKTOP_PIPE_MAX_WIDTH, so no peer pipe is allocated either. Split the recording out of dptxport_call_set_tiled_display_hint() and also run it for a tunnel on 26.6, before the allocation. A J614s now logs DPTXPort: port 0 carries tile (0,0) of a 2x1 tiled 5120x2880 display The allocation reply is unchanged, and so is every other firmware and DP alt mode route. Signed-off-by: Petr Škuta <20834920+petrskuta@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DjDeveloperr
approved these changes
Nov 13, 2026
DjDeveloperr
left a comment
Contributor
There was a problem hiding this comment.
Approve: the tile hint is recorded on the 26.6 desktop path only for a tunnel (dptx_tunnel && DCP_FIRMWARE_V_26_6_DESKTOP); the allocation reply and every other firmware path are unchanged. Merging after a fresh CI run on the current base (dptxep.c changed since the last run).
DjDeveloperr
merged commit Nov 13, 2026
d76c4a2
into
aurora-silicon:integration/aurora
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the desktop 26.6 firmware, SET_TILED_DISPLAY_HINTS goes to the
dual-pipe allocation (dcp_peer_hints_26_6()) and returns from there.
That path never records the tile the port carries, so
dptxport[0].tile_hint stays false and a tiled display behind a
Thunderbolt tunnel can never take its second tile on dpin1
(dcp_tb_split_*): the split waits for the hint, then gives up.
The Studio Display on Thunderbolt 3 is such a sink: two 2560x2880 tiles,
5120 wide, which is under DCP_DESKTOP_PIPE_MAX_WIDTH, so no peer pipe is
allocated either. Split the recording out of
dptxport_call_set_tiled_display_hint() and also run it for a tunnel on
26.6, before the allocation. A J614s now logs
DPTXPort: port 0 carries tile (0,0) of a 2x1 tiled 5120x2880 display
The allocation reply is unchanged, and so is every other firmware and
DP alt mode route.
Testing
On a MacBook Pro 14" M4 Pro (
apple,j614s), os-fw 26.6.2, Studio Display (2022) on Thunderbolt 3, with the trial commits from #1589.dptxport[0].tile_hintstayed false.DPTXPort: port 0 carries tile (0,0) of a 2x1 tiled 5120x2880 display.1:11) raises no HPD while the first tile has no video (see M4 Pro/Max (T6040/T6041): Thunderbolt displays need a DP tunnel pixel clock in the T6040 PHY #1589 and thunderbolt: share an Apple host link between DP tunnels that come up together omacom/linux-aurora#154).aa68b3c81830(W=1, no new warnings).🤖 Generated with Claude Code