Skip to content

drm/apple: dptxep: record the tile hint of a tunneled sink on 26.6 - #1818

Merged
DjDeveloperr merged 2 commits into
aurora-silicon:integration/aurorafrom
petrskuta:j614s-tunnel-tile-hint-26-6
Nov 13, 2026
Merged

DjDeveloperr merged 2 commits into
aurora-silicon:integration/aurorafrom
petrskuta:j614s-tunnel-tile-hint-26-6

Conversation

@petrskuta

Copy link
Copy Markdown
Contributor

On the desktop 26.6 firmware, SET_TILED_DISPLAY_HINTS goes to the
dual-pipe allocation (dcp_peer_hints_26_6()) and returns from there.
That path never records the tile the port carries, so
dptxport[0].tile_hint stays false and a tiled display behind a
Thunderbolt tunnel can never take its second tile on dpin1
(dcp_tb_split_*): the split waits for the hint, then gives up.

The Studio Display on Thunderbolt 3 is such a sink: two 2560x2880 tiles,
5120 wide, which is under DCP_DESKTOP_PIPE_MAX_WIDTH, so no peer pipe is
allocated either. Split the recording out of
dptxport_call_set_tiled_display_hint() and also run it for a tunnel on
26.6, before the allocation. A J614s now logs

DPTXPort: port 0 carries tile (0,0) of a 2x1 tiled 5120x2880 display

The allocation reply is unchanged, and so is every other firmware and
DP alt mode route.

Testing

On a MacBook Pro 14" M4 Pro (apple,j614s), os-fw 26.6.2, Studio Display (2022) on Thunderbolt 3, with the trial commits from #1589.

🤖 Generated with Claude Code

On the desktop 26.6 firmware, SET_TILED_DISPLAY_HINTS goes to the
dual-pipe allocation (dcp_peer_hints_26_6()) and returns from there.
That path never records the tile the port carries, so
dptxport[0].tile_hint stays false and a tiled display behind a
Thunderbolt tunnel can never take its second tile on dpin1
(dcp_tb_split_*): the split waits for the hint, then gives up.

The Studio Display on Thunderbolt 3 is such a sink: two 2560x2880 tiles,
5120 wide, which is under DCP_DESKTOP_PIPE_MAX_WIDTH, so no peer pipe is
allocated either. Split the recording out of
dptxport_call_set_tiled_display_hint() and also run it for a tunnel on
26.6, before the allocation. A J614s now logs

  DPTXPort: port 0 carries tile (0,0) of a 2x1 tiled 5120x2880 display

The allocation reply is unchanged, and so is every other firmware and
DP alt mode route.

Signed-off-by: Petr Škuta <20834920+petrskuta@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@DjDeveloperr DjDeveloperr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve: the tile hint is recorded on the 26.6 desktop path only for a tunnel (dptx_tunnel && DCP_FIRMWARE_V_26_6_DESKTOP); the allocation reply and every other firmware path are unchanged. Merging after a fresh CI run on the current base (dptxep.c changed since the last run).

@DjDeveloperr
DjDeveloperr merged commit d76c4a2 into aurora-silicon:integration/aurora Nov 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants