Skip to content

drm/asahi: G16: run each probe phase in its own stack frame #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DjDeveloperr merged 1 commit into from
Nov 12, 2026
+6 −0
Merged

drm/asahi: G16: run each probe phase in its own stack frame #1669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drivers/gpu/drm/asahi/g16/boot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ impl Orphan {
}

/// Probe-time admission.
#[inline(never)]
pub(crate) fn admit(
pdev: &platform::Device<Core<'_>>,
_dev: &AsahiDrmDevice,
Expand Down Expand Up @@ -658,6 +659,7 @@ fn run(
}

/// Brings the firmware to READY.
#[inline(never)]
pub(crate) fn start(
admitted: Admitted,
dev: &AsahiDrmDevice,
Expand Down
4 changes: 4 additions & 0 deletions drivers/gpu/drm/asahi/g16/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,10 @@ impl Gpu {
impl Firmware {
/// Builds the graphs and the engine after READY. On failure the firmware stays at READY,
/// retained as an orphan of `shared`.
///
/// Out of line, like [`boot::admit`] and [`boot::start`]: each of [`Gpu::new`]'s phases
/// has a large frame, and the probe's stack holds them only one at a time.
#[inline(never)]
fn start_backend(
dev: &AsahiDrmDevice,
booted: boot::Booted,
Expand Down
Loading