Repository navigation
soc: apple: sep: rate-limit the two verify messages from the fresh bring-up - #1590
Merged
Merged
Conversation
…ing-up "Bring a kept Touch ID sensor up afresh for a new prompt" added two plain dev_info! calls on the verify path: one per new authentication that finds the sensor kept, and one when the sensor resets under a capture. Any caller of /dev/sep-bio can trigger both as often as they like, and tools/aurora-sep/tests/test_log_ratelimit.py fails on them. Use dev_info_ratelimited!, as the neighbouring verify messages do. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
commented
Nov 11, 2026
DjDeveloperr
left a comment
DjDeveloperr
left a comment
Contributor
Author
There was a problem hiding this comment.
Codex (GPT-6.1 Sol), reviewing on @DjDeveloperr’s behalf.
Reviewed the two-line diff: it only changes the two new verify-path narrative messages to the same dev_info_ratelimited! form already used nearby. No authentication/state/protocol behavior or message payload changes. It directly addresses the two failures reported by current #973 source job130785000348; no duplicate fix is being opened.
Source-ready pending actual current CI; Host43095270139 and SEP43095270497 remain queued at this read. The separate get_cpu_idle_time minimal-config compilation failure is not fixed by this logging change and is being handled independently. No new hardware or retry was requested.
Contributor
Author
|
Closing and reopening to re-trigger CI; the previous runs stayed queued for 4 hours. |
DjDeveloperr
added a commit
that referenced
this pull request
Nov 12, 2026
Integrate main after #1590 fixed the unrelated source check failure. Preserve the reviewed minimal-config idle-accounting fix, all accounting controls and the workflow path selecting actual KUnit execution. The three-file feature diff is unchanged; original parents and source remain in history. Request fresh validation of the current combined candidate. Assisted-by: LLM
DjDeveloperr
added a commit
that referenced
this pull request
Nov 12, 2026
Integrate main after #1590's SEP rate-limited logging and #1594's CPU_FREQ-independent idle accounting fix landed. Preserve the native26 feature diff, including the reviewed pre-exposure backing admission, saturating accounting and queue ownership tests. All added/removed lines of the 61-file feature diff remain unchanged by the clean merge. Keep all main host registrations/controls plus all fourteen native26 entries, without duplicates; preserve the executable runner and FAIL detection. The native PMP hooks coexist with the exact current-main J613 floor sampler. Original branch ancestry and authorship stay intact. Fresh combined-tree CI remains required. This does not resolve the empty-at-boot activation failure, prove its cause, clear the hardware hold or authorize any new physical trial. Assisted-by: LLM
DjDeveloperr
added a commit
that referenced
this pull request
Nov 12, 2026
…r the merge The SEP's request-path source test from integration (#1590) wants rate-limited or debug messages throughout sep.rs. Five in this series' sleep path were plain: use dev_warn_ratelimited!, dev_err_ratelimited! and dev_info_ratelimited! for them. No logic changes. The last integration merge renamed the DART system-sleep callbacks that tools/asahi/j613-mtp-s2idle-tests.py extracts. Name them apple_dart_system_suspend() and apple_dart_system_resume() again, with the J613 live-MTP code inline as integration has it and this series' firmware-sleep phase choice for every other DART. Give the test stubs for pm_suspend_via_firmware() and the rtkit-helper AP notices, which a firmware-driven sleep alone reaches. The ISP host harness (#1560) didn't model this series' ISP state. Extract isp_cmd_send_chan() with isp_cmd_send(), and take the latch guard out of both for the overwrite control. Give the session fixture fw_restart, fw.started and isp_check_restarted(), and run its capture stop with the firmware running, as a capture only stops while it streams. Give the buffer fixture ISP_FW_RUNNING and clear_bit(). Every check and control stays as it was. Signed-off-by: Diljit Singh <hey@djdev.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1536 ("Bring a kept Touch ID sensor up afresh for a new prompt") added two plain
dev_info!calls on the verify request path insbio.rs:Any caller of
/dev/sep-biocan trigger both, andtools/aurora-sep/tests/test_log_ratelimit.pyrejects them. Since #1536 merged, thesourcecheck fails on integration/aurora itself and on every SEP PR (for example #1587).This switches both to
dev_info_ratelimited!, which the neighbouring verify messages already use ("sensor still registered from the last verify", "the capture ended without a frame"). No other change.Validation:
python3 -m unittest tools.aurora-sep.tests.test_log_ratelimitfails on 9ad7d04 and passes (5/5) with this commit. The macro call takes the same form as the existing ones; compilation is left to CI's rust-build.🤖 Generated with Claude Code