Repository navigation
arm64: dts: apple: t6050-j714s: Add the external displays and the right port's USB4 - #1515
Merged
Merged
Conversation
…ht port's USB4 The MacBook Pro 14-inch (M5 Pro) described its right USB-C port as USB only and gave dcpext0 no display route, so neither USB4 devices nor external displays worked. Describe the right port as on J714c and J716c: t6050-max-atc2.dtsi, with the host DROM from the J714sAP ADT. The router, NHI, PCIe adapter, AP firmware and DART tunables in that file match this board's ADT. Add t6050-j714s-display.dtsi: DisplayPort alt mode on the left-front and right ports and DP tunnels on the right port, driven by dcpext0 and dcpext2, with dcpext1 and dcpext3 as their pairs. The left-back port is the debug port and stays undescribed. The boot loader hands each engine over and publishes its bandwidth scratch and display DART. Signed-off-by: Diljit Singh <hey@djdev.me>
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MacBook Pro 14-inch (M5 Pro, J714s) described its right USB-C port as USB only and gave no display engine a route, so USB4 devices and external displays didn't work. This describes both, from the J714sAP ADT:
t6050-max-atc2.dtsi, as J714c and J716c use, with this board's host DROM. The router, NHI, PCIe adapter, AP firmware and both DARTs' tunables in that file are identical to the J714sAP ADT's. The guards int6050-max.dtsiandt6050-peripherals.dtsinow include J714s.t6050-j714s-display.dtsicovers DP alt mode on the left-front and right ports, and USB4 DP tunnels on the right port.Depends on: #1268, #1270 and #1271 (the T6050 USB4 display stack), and aurora-silicon/aura#158 for the display DARTs. With an older loader the internal handoff is refused and the panel stays on simpledrm.
Other boards: every other T6050 DTB is byte-identical before and after this change. All 11 compile without warnings.
Hardware validation on J714s. The kernel was integration/aurora as of 11-10 plus #1012, #1404, #1268, #1270 and #1271. The DTB was this branch plus this unit's GPU leakage words, which the test loader doesn't fill yet. The loader carried aura#158's patch. Two displays were connected: a USB-C 4K display on the left-front port, and a Thunderbolt 5 dock (Winstars WL-UTD59) with a 4K 240 Hz display, a USB4 NVMe enclosure and USB devices on the right port.
Not tested yet: switching to the 120 Hz and 240 Hz modes, physical hot-plug, and sleep.
🤖 Generated with Claude Code