Repository navigation
HID: magicmouse: report the J616s trackpad's palms - #1510
Merged
RyanTheTide merged 1 commit intoNov 13, 2026
Merged
RyanTheTide merged 1 commit into
RyanTheTide merged 1 commit into
Conversation
The J616s (MacBook Pro M4 Pro) trackpad sends the standard MTP report and classes its contacts like the T6041 one, in the low byte of a record's second word. Recorded on a J616s, three 12 s sessions: session class touch_major tool_major fingers 2, 3 (some 4) <= 227 <= 2475 thumb 1 <= 673 <= 2094 palm 6, 7 1861-2358 2754-2905 Report its palms as MT_TOOL_PALM through the T6041 path. Its rule that makes a contact a palm once the tool area alone passes 2200 stays T6041 only: J616s fingers reach 2475. The class rule (6 and above with a tool area over 1400) separates the sessions above. Only machines whose root is apple,j616s change. Signed-off-by: Jonathan Goyvaerts <jonathan.goyvaerts@gmail.com> Assisted-by: LLM
RyanTheTide
reviewed
Nov 12, 2026
RyanTheTide
left a comment
RyanTheTide
left a comment
Contributor
There was a problem hiding this comment.
The class rule and the T6041-only size rule read right. We will run a trackpad check on our J616s (palms while typing, taps, scroll, gestures, thumb) and come back with the result.
Contributor
|
Ran this on our J616s (M4 Pro), merged on integration e661192, as a one-shot test kernel.
Nobody was at the machine, so we did not do a hands-on palm/tap/gesture pass. The capability change and the unchanged binding are what we could check remotely. |
RyanTheTide
merged commit Nov 13, 2026
7392e90
into
aurora-silicon:integration/aurora
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The J616s (MacBook Pro 16" M4 Pro) trackpad sends the standard MTP report and classes its contacts like the T6041 one (#636), in the low byte of a record's second word. This reports its palms as
MT_TOOL_PALMthrough the T6041 path.Recorded on a J616s, three 12 s sessions:
The class rule (6 and above with a tool area over 1400) separates these. The T6041 rule that makes a contact a palm once the tool area alone passes 2200 stays T6041 only (new
mtp_palm_size), because J616s fingers reach 2475. Only machines whose root isapple,j616schange; T6041 behaves as before.Testing: on the J616s daily kernel since 11-07, where palm rejection was checked by hand in normal use. Builds clean on integration/aurora 451dc70 (W=1); checkpatch clean.
🤖 Generated with Claude Code