Repository navigation
Remove APIF - #1363
Merged
Merged
Remove APIF#1363
Conversation
APIF is old SPTM support that doesn't need to be in tree. Drop the APIF MMIO transport, its DART and SART providers, the APIF mailbox profile, its config fragment and selftests, and the headers only APIF consumers used. SART goes back to its MMIO path. Signed-off-by: Diljit Singh <hey@djdev.me>
Remove the APIF MMIO, DART and SART bindings and the APIF ASCWrap v6 compatible, and the APIF host wording in the N1 Control binding. Signed-off-by: Diljit Singh <hey@djdev.me>
Remove the APIF platform, driver and N1 transport pages, their index entries and the APIF MAINTAINERS entries. Signed-off-by: Diljit Singh <hey@djdev.me>
DjDeveloperr
force-pushed
the
cleanup/remove-apif
branch
from
November 9, 2026 18:03
3621508 to
9310f76
Compare
This was referenced Nov 9, 2026
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APIF is old SPTM support that doesn't need to be in tree. This removes all of it from
integration/aurora. Most of it came in with the shared T6050 APIF base (d9d9ee6, PR #472). Later additions, such as #841's 61 lines inapple-dart-apif.c, go with their files.Removed
drivers/firmware/aurora-apif-mmio.c), the APIF DART (drivers/iommu/apple-dart-apif.c) and the APIF SART (drivers/soc/apple/apple-sart-apif.c), withAURORA_APIF_MMIO,APPLE_DART_APIF,APPLE_SART_APIFand their Makefile lines.apple-dart-apif.h,pci-apple-apif.handsoc/aurora/apif-mmio.h. Alsosoc/apple/display-event-{log,debugfs}.h: nothing in tree includes them, and their only user is usb: typec: tipd: Reconcile T6050 SPMI and display events #487, part of the APIF series.sart-backend.hand the backend indirection insart.c. Only the APIF SART used it. With no backend set, the existing MMIO path runs unchanged.apple,t6050-apif-ascwrap-v6profile inmailbox.c. No DT uses it.arch/arm64/configs/aurora-apif.config, andtools/testing/selftests/aurora-apif/with itsTARGETSline.aurora,apif-mmio,apple,dart-apif,apple,sart-apif, and the APIF compatible inapple,ascwrap-v6.aurora-apif*.rstpages, their toctree entries, the "AURORA PLATFORM MMIO INTERFACE" section, and the Centauri section's link to the APIF doc.Kept
These came with the APIF base, but native code in tree now uses them:
pmp.rs,apple,t6050-pmp-v2.apple_mbox_ascwrap_v6_get_cpu_state(): used by g18.apple_centauri_control_ready(): used bycentauri/t6050,btcentauri_t6050.apple_dp_phy_link_config(): used byatc-t6050-dp.apple_dpxbar_link_configure(): used byapple-display-crossbar.Grep
git grep -n -E "(^|[^A-Za-z])(apif|APIF)([^a-z]|$)"now matches only the NXP RTC register bit:Build
All builds ran on the shared host under the kbuild lock, at nice 19 with -j6.
7.3.0-m5-apifrm: the running7.3.0-m5-argbsource with these three commits on top.Image modules dtbswith the integration config. After olddefconfig the config differs from the running kernel's in 0 lines.drivers/{soc/apple,iommu,firmware,mailbox}/at W=1, base vs head.display-gate.c.sart.oandmailbox.o: 0 warnings.Hardware (M5 Pro J714s, SSD boot)
7.3.0-m5-apifrmis the running7.3.0-m5-argbsource with these three commits. I installed it over SSH as its own release, rebooted, then rolled back and compared it with a fresh argb boot.graphical.targetwith Hyprland running.ssh m5-ssdcame back 10 s after the reboot.nvme0n1p5(ext4 rw) through45dcc0000.nvme. SART41dc50000is bound.2302600000and2302e00000.apple-drmbound.auroradriver is bound to2300000000.gpu, with card0/card1.xart_writes=0 provision_keybag=0).phramdevice's address, which also changes between two boots of argb itself (10006000000 vs 10006378000).7.3.0-m5-argbwith prev7.3.0-m5-integration. The ESP sets and the composed Stage 2 are byte-identical to the start.Open PRs
Once this merges, these October APIF-series PRs get closed, since they add or depend on APIF code:
apple_apif_pcie_cycle()and matchesapple,t6050-pcie-apif.aurora-apif.config.The rest of that series is native and stays open for the owner to decide:
#778 puts a new test under
tools/testing/selftests/aurora-apif/, so it needs to move that test.#1208's
sart.chunks have the removed backend lines as context, so expect a small conflict there.🤖 Generated with Claude Code