Repository navigation
arm64: dts: apple: t8132-j773g: Keep the PMC power state on - #1181
Merged
RyanTheTide merged 1 commit intoNov 9, 2026
Merged
RyanTheTide merged 1 commit into
RyanTheTide merged 1 commit into
Conversation
This was referenced Nov 7, 2026
techmore
force-pushed
the
j773g/ps-pmc-always-on
branch
from
November 8, 2026 05:20
9b465c5 to
324736f
Compare
techmore
marked this pull request as draft
November 8, 2026 05:20
Contributor
Author
|
Per |
techmore
force-pushed
the
j773g/ps-pmc-always-on
branch
2 times, most recently
from
November 8, 2026 08:23
e50b1d8 to
f947fb2
Compare
Contributor
Author
|
Update: Sean Dolbec, the human submitter, added his DCO sign-off to the current commit(s) on 2026-11-08; the earlier unsigned status is superseded. |
techmore
force-pushed
the
j773g/ps-pmc-always-on
branch
from
November 8, 2026 09:32
f947fb2 to
7335414
Compare
Once the PMP runs on the M4 Mac mini (J773g), its firmware accesses the PMC block at 0x382800000. Linux treats its PMGR power state, ps_pmc, as an ordinary domain without consumers. J713 disables the domain in its board PMGR policy; J773g has no such policy yet. Mark ps_pmc always-on for J773g. Linux then keeps the domain on. Pavel Shago's J773g tree ended up with the same property in his commit of 2026-10-19, which predates ours. He sets it for all T8132 boards and reports a DCP SError on HDMI unplug. His observation and explanation have not been reproduced here. On one J773g (10-core GPU, system firmware 27.0, OS firmware 26.6.2), using a custom m1n1 stage 2 (build/commit unavailable) and Omarchy (Arch, release unavailable), v38 and v40 differed by this property: v38 had a PMP firmware crash and v40 logged PMP started without it. Across several configurations, 12 logs without the property showed the crash and 11 with it showed PMP started without the crash. Two further boots with PMC enabled left the board dead about 22 s after entry; no kernel log was kept for v34/v35. Attribution to ps_pmc rests on v42/v43 passing with the property, not a matched pair. v41 also changed the PMP register window and still crashed without the property. The driver never logged that an always-on domain was off at boot, which supports an inference that ps_pmc was on at handoff. These boots used pd_ignore_unused and clk_ignore_unused. A power-off was not observed; whether Linux turns the domain off without the property and causes the firmware fault remains inferred, not observed. These boots used our own J773g device tree on an older kernel. This tree's t8132-j773g.dts with this patch has not been booted on hardware. Link: shgpavel/linux-asahi@172d11a Assisted-by: LLM checkpatch Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
techmore
force-pushed
the
j773g/ps-pmc-always-on
branch
from
November 8, 2026 09:59
7335414 to
b6425fc
Compare
techmore
marked this pull request as ready for review
November 8, 2026 10:18
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
RyanTheTide
merged commit Nov 9, 2026
46c01bc
into
aurora-silicon:integration/aurora
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the J773g PMC power state on while the retained PMP firmware and its Linux consumers are active. This is the one-line DT shape used by the successful J773g bring-up and independently matches Pavel Shago's earlier J773g work.
Results
apple,always-ononps_pmc, the retained PMP, PMC, CLPC, static voter, AGX request, GPU compute, and HDMI path remained operational on one J773g.ps_pmc, marking it firmware-owned, and the independently reported HDMI-unplug trigger were not tested by us.The observed result is that the property prevents the crash on the bring-up stack. The proposed power-off mechanism remains an inference because the transition itself was not captured.
Validation
--no-signoff, 0 errors, 0 warnings, 0 checks.dtbs_checkhad no new findings versus the same base; existing Apple DT/dtschema findings were unchanged.The content is unchanged by the trailer-only compliance rewrite, so no rebuild was needed. This PR stays draft until an exact-head J773g boot is recorded.
No serial number, network address, raw device-tree/ADT dump, per-unit firmware image, calibration data, or core dump is included.
The human submitter, Sean Dolbec, added his own DCO sign-off to each commit on 2026-11-08.