Repository navigation
arm64: dts: apple: add the J714c (MacBook Pro 14-inch, M5 Max) - #1085
Conversation
The 14-inch M5 Max is the same one-die T6050 as the J716c, so the board file reuses t6050-max.dtsi and enables the set the J716c file enables: CPUs, AIC, NVMe, SMC, boot framebuffer, DockChannel console, keyboard and trackpad, and the N1 Wi-Fi/Bluetooth on PCIe port 0. This PR is stacked on the J716c device tree PR (#945). Three values differ from the J716c file: - the N1 firmware name and platform ID (j714c-ftab.bin, board 0x0a), - the trackpad firmware (tpmtfw-j714c.bin), - the trackpad AFE reset is owned by the MTP firmware (power method 2, apple,firmware-managed-reset), so the board has no smc_pcio reset line. Add the apple,j714c compatible to the binding. Signed-off-by: Joshua Warren <816217+joshuaswarren@users.noreply.github.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
|
lgtm & thanks @joshuaswarren as always! |
|
Thanks for the merge! J714c now rides the j716c/dt stack, so both DTs land in main together when #945 goes in. |
The M5 Max 14-inch MacBook Pro (J714c) has no device tree in this repo. It is the same one-die T6050 as the J716c, so this adds a board file on top of
t6050-max.dtsifrom #945 (this PR is stacked on #945 and will be retargeted when #945 merges). It enables the set the J716c board file enables: CPUs, AIC, NVMe, SMC, boot framebuffer, DockChannel console, keyboard and trackpad, and the N1 Wi-Fi/Bluetooth on PCIe port 0. Everything else stays disabled until it is described for this board.Three values differ from
t6050-j716c.dts:apple/centauri/j714c-ftab.binand platform ID0x000a6050(board0x0a).apple/tpmtfw-j714c.bin.apple,power-method = <2>withapple,firmware-managed-reset), so the board has nosmc_pcioreset line and noapple,output-commands.It also adds
apple,j714ctoDocumentation/devicetree/bindings/arm/apple.yaml, in a new M5 Max block. The J716c has no binding entry yet.Where the J714c values come from. The N1 platform ID, both firmware names and the MTP reset mode are taken from
edimoldovan/linux-aurorabrancht6050-j714cat4f8b07f3, where they ran on a J714c: its merge commit671fd38ereports "wlan0 and hci0 come up, iwd lists the networks on 2.4 and 5 GHz" withj714c-ftab.bin, andDocumentation/arch/arm64/apple-j714c.rstthere reports a BusyBox shell with the built-in keyboard working. The PCIe port 0 registers, interrupt, DART streams and PERST# pin 80 are the J716c's; the same commit's comment says the J714c's ADT has the same port.Testing. Not booted by this PR's author: no J714c is available here. What ran:
cppplusdtc -@(DTC 1.7.2, default warnings on) buildt6050-j714c.dtson this stack with no warnings: a 41137-byte DTB, sha25667ab18372ee78016484aef76eb1a7c5159c18cc856b461ad5d1b68de40bfff24.t6050-j716c.dtsbuilds the same way from the same base.dt-doc-validateaccepts the editedapple.yaml.dt-validateof the DTB and a boot of this tree on a J714c have not run. A boot on a J714c is the open check.