Repository navigation
fix(prebuild): do not embed the 142 MiB AIST model in published Node addons - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the prebuild pipeline to ensure published Node addons are “thin” bindings by preventing the AIST GGUF model from being embedded or fetched during the CMake configure/build step, avoiding oversized npm tarballs and publish failures.
Changes:
- Pass
-DCORTEXT_EMBED_AIST_MODEL=OFFand-DCORTEXT_FETCH_AIST_MODEL=OFFwhen configuring CMake for prebuild addons. - Extend the prebuild script provenance/contract test to assert those flags are present in the build script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/prebuilds.test.mjs | Adds assertions ensuring the prebuild script includes the new CMake flags. |
| scripts/build-prebuild.mjs | Adds the new CMake configure flags to disable embedding/fetching the AIST model. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
289
to
292
| "-DCORTEXT_GGML_OPENMP=OFF", | ||
| "-DCORTEXT_EMBED_AIST_MODEL=OFF", | ||
| "-DCORTEXT_FETCH_AIST_MODEL=OFF", | ||
| "-DCORTEXT_NODE_EXECUTABLE=" + args.node, |
Comment on lines
+290
to
+291
| "-DCORTEXT_EMBED_AIST_MODEL=OFF", | ||
| "-DCORTEXT_FETCH_AIST_MODEL=OFF", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The six-host release matrix now produces verified addons, but the npm
tarball is 541 MB because CORTEXT_EMBED_AIST_MODEL defaults ON and the
Unix addons each bake in the ~142 MiB AIST GGUF (MSVC cannot .incbin, so
Windows stays ~4 MB). npm publish then fails with ERR_STRING_TOO_LONG
(and the registry would reject a 541 MB package anyway).
Published Node addons should be thin bindings. The model is loaded at
runtime, not vendored in the npm tarball. This passes
-DCORTEXT_EMBED_AIST_MODEL=OFF and -DCORTEXT_FETCH_AIST_MODEL=OFF to the
prebuild CMake configure.