Repository navigation
fix: define NOMINMAX for Windows addons - #12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves a remaining Windows native build failure by ensuring NOMINMAX is defined for Windows addon builds, preventing Windows max/min macros from conflicting with C++ std::max usage during core telemetry compilation.
Changes:
- Adds
/DNOMINMAXto the Windows CMake C++ flags used by the prebuild orchestration script. - Updates the corresponding test assertion to match the new Windows CMake flag string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/build-prebuild.mjs |
Appends /DNOMINMAX to -DCMAKE_CXX_FLAGS on Windows prebuild configuration. |
tests/prebuilds.test.mjs |
Updates the regex assertion to reflect the new Windows CMake flag string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining Windows native matrix error: core telemetry uses std::max, which conflicts with the Windows max macro unless NOMINMAX is defined.
Adds /DNOMINMAX alongside /EHsc, keeps CORTEXT_WARNINGS_AS_ERRORS=OFF for the native orchestration, and preserves ARM clang-cl opt-in. The prior run failed before collection/publication.