Repository navigation
fix: disable fatal warnings in native builds - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the Windows native-addon prebuild CMake configuration to keep warnings visible while avoiding “warnings as errors” failures (notably from external deps like Eigen/hnswlib), while preserving /EHsc and the existing clang-cl ARM64 opt-in behavior.
Changes:
- For Windows builds, switches from hardcoded warning-disables in
CMAKE_CXX_FLAGSto settingCORTEXT_WARNINGS_AS_ERRORS=OFFand keeping-DCMAKE_CXX_FLAGS=/EHsc. - Updates the corresponding test assertion to match the new Windows configure argument shape.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/prebuilds.test.mjs | Updates the test regex to assert the new Windows CMake configure args are present in the build script source. |
| scripts/build-prebuild.mjs | Changes Windows CMake configuration to disable warnings-as-errors via CORTEXT_WARNINGS_AS_ERRORS=OFF while retaining /EHsc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses core's explicit CORTEXT_WARNINGS_AS_ERRORS=OFF for Windows native addon builds while retaining
/EHscand the ARM clang-cl opt-in. This keeps warnings visible but avoids failing on external Eigen/hnswlib and known core diagnostics. Previous v1.3.3 run failed before collection/publication.