Repository navigation
fix: enable Windows C++ exception unwinding - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Windows native addon builds failing under MSVC due to missing C++ exception unwinding semantics by adding /EHsc to the CMake C++ flags used by the prebuild script, and updating the corresponding regression test to assert the new flag is present.
Changes:
- Add
/EHscto the Windows-DCMAKE_CXX_FLAGS=...passed byscripts/build-prebuild.mjs. - Update
tests/prebuilds.test.mjsto assert the build script includes/EHscin the Windows CMake flags.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/prebuilds.test.mjs | Updates the test assertion to include /EHsc in the expected Windows CMake flags string. |
| scripts/build-prebuild.mjs | Adds /EHsc to the Windows CMake C++ flags to prevent MSVC C4530 failures under warning-as-error settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
/EHscto Windows native addon CMake flags. The v1.3.3 matrix reached compilation but MSVC treated C4530 as an error in standard headers/core sources. This follow-up fixes both Windows targets; no artifacts were published from the failed run.