Repository navigation
fix(cmake): avoid Windows LNK1149 cortext.lib name collision on the Node addon - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CMake configuration for the optional Node.js N-API addon build to prevent an MSVC linker failure caused by the addon’s generated import library name colliding with the already-produced static library name (cortext.lib). This supports the broader Windows port work needed for the @augmem/cortext npm release pipeline.
Changes:
- Set
ARCHIVE_OUTPUT_NAMEforcortext_nodetocortext_nodeso the generated import library becomescortext_node.libinstead ofcortext.lib. - Set
ARCHIVE_OUTPUT_DIRECTORYforcortext_nodeto align the import library output location with the addon output directory.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 4 of the Windows port for the npm release of @augmem/cortext v1.3.3
(follow-up to PRs #22-#24). Compilation now succeeds; both Windows matrix
jobs fail at link:
cortext_node is a MODULE with OUTPUT_NAME "cortext" (so the addon is
cortext.node) and it privately links the static cortext library, which
already emits cortext.lib. MSVC also writes an import library named after
OUTPUT_NAME, so input and output are both cortext.lib.
This sets ARCHIVE_OUTPUT_NAME to cortext_node so the unused import library
is cortext_node.lib and no longer collides.