Skip to content

fix: link Windows Node addon against node.lib #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabewillen merged 1 commit into from
Aug 7, 2026
Merged

fix: link Windows Node addon against node.lib #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ option(CORTEXT_ENABLE_MSAN "Enable MemorySanitizer (Clang only)" OFF)

set(CORTEXT_NODE_EXECUTABLE "" CACHE FILEPATH "Path to the node executable used for Node.js addon builds")
set(CORTEXT_NODE_INCLUDE_DIR "" CACHE PATH "Path to Node.js headers used for Node.js addon builds")
set(CORTEXT_NODE_LIBRARY "" CACHE FILEPATH
"Path to the Node.js import library used for Windows addon builds")

if(EMSCRIPTEN AND BUILD_TESTING)
message(STATUS "Disabling tests for WebAssembly builds (not supported).")
Expand Down Expand Up @@ -883,13 +885,13 @@ if(CORTEXT_BUILD_NODE_BINDINGS AND NOT EMSCRIPTEN)
)
endif()

execute_process(
COMMAND "${CORTEXT_NODE_EXECUTABLE}" -p "require('path').dirname(require('path').dirname(process.execPath))"
OUTPUT_VARIABLE CORTEXT_NODE_PREFIX
OUTPUT_STRIP_TRAILING_WHITESPACE
COMMAND_ERROR_IS_FATAL ANY
Comment on lines +888 to +892
)
if(NOT CORTEXT_NODE_INCLUDE_DIR)
execute_process(
COMMAND "${CORTEXT_NODE_EXECUTABLE}" -p "require('path').dirname(require('path').dirname(process.execPath))"
OUTPUT_VARIABLE CORTEXT_NODE_PREFIX
OUTPUT_STRIP_TRAILING_WHITESPACE
COMMAND_ERROR_IS_FATAL ANY
)
set(CORTEXT_NODE_INCLUDE_DIR "${CORTEXT_NODE_PREFIX}/include/node")
endif()

Expand Down Expand Up @@ -918,7 +920,28 @@ if(CORTEXT_BUILD_NODE_BINDINGS AND NOT EMSCRIPTEN)
RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/ffi/node"
)

if(APPLE)
if(WIN32)
if(NOT CORTEXT_NODE_LIBRARY)
find_file(_cortext_node_library
NAMES node.lib
PATHS "${CORTEXT_NODE_PREFIX}"
PATH_SUFFIXES "" x64 lib
NO_DEFAULT_PATH
)
set(CORTEXT_NODE_LIBRARY "${_cortext_node_library}" CACHE FILEPATH
"Path to the Node.js import library used for Windows addon builds"
FORCE
)
endif()
if(NOT CORTEXT_NODE_LIBRARY OR NOT EXISTS "${CORTEXT_NODE_LIBRARY}")
message(FATAL_ERROR
"Node.js import library node.lib was not found under "
"${CORTEXT_NODE_PREFIX} (searched the prefix, x64, and lib). "
"Set CORTEXT_NODE_LIBRARY to the node.lib path."
)
Comment on lines +925 to +941
endif()
target_link_libraries(cortext_node PRIVATE "${CORTEXT_NODE_LIBRARY}")
elseif(APPLE)
target_link_options(cortext_node PRIVATE "-undefined" "dynamic_lookup")
set_property(TARGET cortext_node APPEND PROPERTY BUILD_RPATH
"@loader_path/../.."
Expand Down
4 changes: 3 additions & 1 deletion ffi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ Language packages are published from sibling repositories:
- [cortext.wasm](https://github.com/augmem/cortext.wasm)

Enable the Node addon via CMake (`CORTEXT_BUILD_NODE_BINDINGS`) or Zig
(`-Dnode-addon=true`).
(`-Dnode-addon=true`). On Windows, CMake searches the Node prefix for
`node.lib` (including `x64/` and `lib/`); set `-DCORTEXT_NODE_LIBRARY=...` to
override the import-library path when Node is installed elsewhere.
Loading