fix(ci): folded uses: scalars can't carry an inline # comment (startup failure) - #5
Merged
Conversation
…lure)
The v0.1.0 re-pin appended '# v0.1.0' to folded 'uses: >-' scalars, where '#' is
NOT a comment — it became part of the action ref ('...@sha # v0.1.0'), an invalid
'uses:' value that startup-failed ci.yml, quality-gates.yml, and release.yml. Keep
the bare v0.1.0 SHA on folded lines; the regular (single-line) catalog-admission
uses: keeps its '# v0.1.0' comment, which is valid YAML.
There was a problem hiding this comment.
Pull request overview
Fixes GitHub Actions workflow startup failures caused by appending # v0.1.0 comments to folded uses: >- scalars (where # becomes part of the scalar value, making the resolved uses ref invalid).
Changes:
- Remove inline
# v0.1.0suffixes from foldeduses: >-workflow references so the resolvedusesvalues are valid. - Remove stray blank folded-scalar lines that would otherwise introduce unexpected newlines into
usesvalues. - Keep workflow behavior the same while restoring YAML/actionlint correctness.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Removes invalid inline comments from folded uses refs across gate/attestation jobs to prevent workflow parse/startup failures. |
.github/workflows/quality-gates.yml |
Removes invalid inline comments from folded uses refs so quality-gates workflow loads correctly. |
.github/workflows/ci.yml |
Removes invalid inline comments (and a blank folded-scalar line) from folded uses refs so CI workflow loads correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
+29
| pin-check: | ||
| permissions: | ||
| contents: read | ||
| uses: >- | ||
| attested-delivery/.github/.github/workflows/pin-check.yml@f211de97395ced798da52e28d89d79c22b3020ee # v0.1.0 | ||
|
|
||
| attested-delivery/.github/.github/workflows/pin-check.yml@f211de97395ced798da52e28d89d79c22b3020ee |
|
|
||
| attested-delivery/.github/.github/workflows/pin-check.yml@f211de97395ced798da52e28d89d79c22b3020ee | ||
| # Centralized, verified actionlint fetch. | ||
| # attested-delivery/.github @ b314c29 (#6 — in-step PATH fix) |
Comment on lines
42
to
+43
| uses: >- | ||
| attested-delivery/.github/.github/workflows/reusable-sast-codeql.yml@f211de97395ced798da52e28d89d79c22b3020ee # v0.1.0 | ||
| attested-delivery/.github/.github/workflows/reusable-sast-codeql.yml@f211de97395ced798da52e28d89d79c22b3020ee |
Comment on lines
139
to
+140
| uses: >- | ||
| attested-delivery/.github/.github/workflows/reusable-sast-codeql.yml@f211de97395ced798da52e28d89d79c22b3020ee # v0.1.0 | ||
| attested-delivery/.github/.github/workflows/reusable-sast-codeql.yml@f211de97395ced798da52e28d89d79c22b3020ee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken main from the v0.1.0 re-pin. That change appended
# v0.1.0to foldeduses: >-scalars, where#is literal — so the action ref became...@f211de9 # v0.1.0, an invaliduses:value that startup-failedci.yml,quality-gates.yml, andrelease.yml.Fix: bare v0.1.0 SHA on folded lines (still tracks v0.1.0). The regular single-line
catalog-admissionuses:keeps its# v0.1.0comment. actionlint clean; YAML parse confirms no#in any resolvedusesvalue.