Skip to content

Feat/772 access requests - #805

Open
vbeni30 wants to merge 1 commit into
devfrom
feat/772-access-requests
Open

Feat/772 access requests#805
vbeni30 wants to merge 1 commit into
devfrom
feat/772-access-requests

Conversation

@vbeni30

@vbeni30 vbeni30 commented Aug 22, 2026

Copy link
Copy Markdown

Review Ask Status

Here’s how each point maps:

Review ask Status
Dialog tests (success, missing director, validation, service failure) ✅ Already covered by request-access-dialog.test.tsx (on dev, included in the rebased branch)
Verify /api/interactions/access-request fetch ✅ Covered by api.test.ts — asserts POST to the correct endpoint with JSON body + auth header
API/action-level assertion (not just mocked dialog action) ✅ Added actions.test.tssubmitAccessRequestAction delegates to submitAccessRequest and maps success/error
Entry-point check (report + collection) ✅ Added entry-point tests for report action rail (entity-engagement-rail-actions.test.tsx) and report cards in collection listings (entity-card-footer.test.tsx)
Merge conflict resolved ✅ PR is now MERGEABLE with mergeStateStatus: CLEAN

Test Coverage Stack

Dialog UI
  → request-access-dialog.test.tsx
    (mocks action — fine for UI)

Action wiring
  → actions.test.ts
    (NEW)

API fetch
  → api.test.ts
    (POST /api/interactions/access-request)

Entry points
  → entity-engagement-rail-actions.test.tsx
    (NEW — report rail)

  → entity-card-footer.test.tsx
    (NEW — collection report cards)

Seme30
Seme30 previously requested changes Aug 31, 2026

@Seme30 Seme30 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against issue #772. The PR adds passing dialog tests for successful submission, a missing director, backend validation feedback, and service failure. However, it still mocks submitAccessRequestAction, so it does not verify the /api/interactions/access-request request or confirm both report and collection entry points use it. Please add one API/action-level fetch assertion (or an integration test) and an entry-point check. PR #805 also needs its merge conflict resolved before it can merge.

Add submitAccessRequestAction wiring tests and entry-point checks for the report action rail and collection report card footer. Rebased onto dev to resolve merge conflict.

#772
@vbeni30
vbeni30 force-pushed the feat/772-access-requests branch from f20ce59 to 05b38df Compare September 2, 2026 15:36
@Seme30
Seme30 dismissed their stale review September 2, 2026 16:08

Addressed in commit 05b38df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants