Feat/772 access requests - #805
Open
vbeni30 wants to merge 1 commit into
Open
Conversation
Seme30
previously requested changes
Aug 31, 2026
Seme30
left a comment
Contributor
There was a problem hiding this comment.
Reviewed against issue #772. The PR adds passing dialog tests for successful submission, a missing director, backend validation feedback, and service failure. However, it still mocks submitAccessRequestAction, so it does not verify the /api/interactions/access-request request or confirm both report and collection entry points use it. Please add one API/action-level fetch assertion (or an integration test) and an entry-point check. PR #805 also needs its merge conflict resolved before it can merge.
Add submitAccessRequestAction wiring tests and entry-point checks for the report action rail and collection report card footer. Rebased onto dev to resolve merge conflict. #772
vbeni30
force-pushed
the
feat/772-access-requests
branch
from
September 2, 2026 15:36
f20ce59 to
05b38df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Ask Status
Here’s how each point maps:
request-access-dialog.test.tsx(ondev, included in the rebased branch)/api/interactions/access-requestfetchapi.test.ts— assertsPOSTto the correct endpoint with JSON body + auth headeractions.test.ts—submitAccessRequestActiondelegates tosubmitAccessRequestand maps success/errorentity-engagement-rail-actions.test.tsx) and report cards in collection listings (entity-card-footer.test.tsx)MERGEABLEwithmergeStateStatus: CLEANTest Coverage Stack