Skip to content

Sync Python SDK models from atlanhq/models#949

Open
atlan-ci wants to merge 1 commit into
mainfrom
sync-models-20260602-100940
Open

Sync Python SDK models from atlanhq/models#949
atlan-ci wants to merge 1 commit into
mainfrom
sync-models-20260602-100940

Conversation

@atlan-ci
Copy link
Copy Markdown
Collaborator

@atlan-ci atlan-ci commented Jun 2, 2026

Summary

This PR syncs the generated Python SDK models from the atlanhq/models repository.

Changes

Auto-generated Python model files from Pkl type definitions.

Test Plan

  • Verify generated models are syntactically correct
  • Run existing tests against updated models

🤖 This PR was automatically created by the sync-python-sdk workflow.

Source commit: 7e8ff3a75b808b70e4cc736625370b70030e4a54
Source ref: refs/heads/master

Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@claude
Copy link
Copy Markdown

claude Bot commented Jun 2, 2026

Review Summary

Critical Issue: requirements.txt was emptied - This file went from 274 lines to 0 in this PR. This appears unintentional in a model sync PR and could break CI/development workflows. Please verify if this deletion was intended.

Breaking API Changes (Attribute Renames): Many attributes were renamed from type-specific prefixes to generic prefixes. This is a breaking change for SDK consumers using the old attribute names:

  • column_* to sql_* (e.g., column_distinct_values_count to sql_distinct_values_count)
  • calculation_view_* to sql_*
  • atlan_app_tool_* to atlan_app_*
  • atlan_app_workflow_* to atlan_app_*

SDK Method Removal: The validate(), minimize(), and relate() methods were removed from most asset classes. Note: business_policy_log.py, business_policy_exception.py, and business_policy_incident.py still have these methods (files not modified), creating an inconsistency.

New Model Types: SigmaDataModel and SigmaDataModelColumn added. BusinessPolicyException, BusinessPolicyIncident, and BusinessPolicyLog removed from _init_business_policy.py exports.

Architecture Improvement: The __init__.py rewrite to use lazy loading via __getattr__ and AST scanning is a good improvement that reduces memory usage.

Security Review: No security concerns identified - no credential exposure, TLS verification unchanged.


Review generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant