CU-86c2y3vu1-linting-should-run-opening-a-pr

.github/workflows/linting-checks.yml

@@ -1,15 +1,15 @@
-name: Post-Merge Checks
+name: PR Linting Checks
 
 on:
-  push:
-    branches:
-      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 permissions:
   contents: read
+  pull-requests: write
 
 jobs:
-  pre-commit-checks:
+  linting-checks:
     runs-on: ubuntu-latest
 
     steps:
@@ -21,14 +21,17 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.11'
+          python-version: '3.11.14'
           cache: 'pip'
 
-      - name: Install dependencies
+      - name: Install requirements
         run: |
           python -m pip install --upgrade pip
           pip install -r requirements.txt
 
+      - name: Install dbt dependencies
+        run: dbt deps
+
       - name: Set up Terraform
         uses: hashicorp/setup-terraform@v3
 

.pre-commit-config.yaml

@@ -8,12 +8,21 @@ repos:
         include: \.(yaml|yml)$
 
   - repo: https://github.com/sqlfluff/sqlfluff
-    rev: 3.2.3
+    rev: 4.2.0
     hooks:
       - id: sqlfluff-lint
-        additional_dependencies: ['dbt-bigquery==1.8.1', 'sqlfluff-templater-dbt==3.2.3']
+        additional_dependencies:
+          - dbt-core==1.11.2
+          - dbt-bigquery==1.11.0
+          - sqlfluff==4.2.0
+          - sqlfluff-templater-dbt==4.2.0
+
       - id: sqlfluff-fix
-        additional_dependencies: ['dbt-bigquery==1.8.1', 'sqlfluff-templater-dbt==3.2.3']
+        additional_dependencies:
+          - dbt-core==1.11.2
+          - dbt-bigquery==1.11.0
+          - sqlfluff==4.2.0
+          - sqlfluff-templater-dbt==4.2.0
 
   - repo: https://github.com/dbt-checkpoint/dbt-checkpoint
     rev: v1.2.1

.sqlfluff

@@ -25,15 +25,15 @@ align_scope = bracketed
 
 # AS should be there in table aliases
 [sqlfluff:rules:aliasing.table]
-aliasing.table = explicit
+aliasing = explicit
 
 # AS should be there for renamed columns
 [sqlfluff:rules:aliasing.column]
-aliasing.column = explicit
+aliasing = explicit
 
 # AS should be there after SUM(), MAX() etc
 [sqlfluff:rules:aliasing.expression]
-aliasing.expression = explicit
+aliasing = explicit
 
 # use ALL numbers in GROUP BY, ORDER BY
 [sqlfluff:rules:ambiguous.column_references]

.sqlfluffignore

@@ -0,0 +1,3 @@
+target
+dbt_packages
+logs

requirements.txt

@@ -1,7 +1,7 @@
 dbt-core==1.11.2
 dbt-bigquery==1.11.0
-sqlfluff==4.0.0
-sqlfluff-templater-dbt==4.0.0
+sqlfluff==4.2.0
+sqlfluff-templater-dbt==4.2.0
 yamllint==1.35.1
 pylint==3.3.1
 pymarkdownlnt==0.9.24